Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deprecation of this package. #14

Merged
merged 5 commits into from
Aug 14, 2019
Merged

Document deprecation of this package. #14

merged 5 commits into from
Aug 14, 2019

Conversation

dwt
Copy link
Contributor

@dwt dwt commented Aug 12, 2019

According to #8 and #12 much of the discussion that is linked in these issues this package is broken and not usable as is (and probably hard / impossible to fix without a big investment).

Since this is known by many long time community members, this should be documented at least in the readme, so that other community members have a chance to find out about this fact more easily.

@dwt
Copy link
Contributor Author

dwt commented Aug 12, 2019

I would like to recommend alternatives in the readme, but I don't really know what a valid recommendation would be. Suggestions are welcome. :-)

@d-maurer
Copy link

d-maurer commented Aug 12, 2019 via email

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with deprecating the package.
Please also add a note to the change log.
Could you please incorporate the suggestions of @d-maurer for alternatives?

README.rst Outdated Show resolved Hide resolved
dwt and others added 3 commits August 13, 2019 08:54
@dwt dwt requested a review from icemac August 13, 2019 07:10
@dwt
Copy link
Contributor Author

dwt commented Aug 13, 2019

Do these changes address the raised concerns? I have also updated #15 to include these changes.

I really think there should be a warning / log entry too so people still using this package have a chance to discover that it actually got deprecated (and I'm probably doing it wrong to warn them like I do, so some feedback there is also really appreciated).

@d-maurer
Copy link

... I will soon publish dm.zope.session (as an alternative to Products.Transience). It will be less prone to ConflictError if intensively used (e.g. by every request) and supports features for (custom) detection (and maybe handling) of session based DOS attacks. It also sketches the necessary steps for its use (many of them similar to those necessary to use the standard Zope sessions on a "normal" storage.

dm.zope.session is now published: "https://pypi.org/project/dm.zope.session/".

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dwt dwt merged commit c5d99c2 into master Aug 14, 2019
@dwt
Copy link
Contributor Author

dwt commented Aug 14, 2019

Thanks. @icemac could you also take a look at #15?

@dwt dwt deleted the document_deprecation branch August 14, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants