Skip to content

Commit

Permalink
Describe the changes explicitely in Changes.rst (and not only via a…
Browse files Browse the repository at this point in the history
… reference to #58).

Change comment formatting in the test suite.
  • Loading branch information
d-maurer committed May 4, 2019
1 parent cde2996 commit 61a1168
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 11 deletions.
10 changes: 8 additions & 2 deletions CHANGES.rst
Expand Up @@ -5,8 +5,14 @@
2.4.1 (unreleased)
==================

- Fix transaction manager run problems
(`#58 <https://github.com/zopefoundation/transaction/issues/58>`_)
- ``TransactionManager.run`` now commits/aborts the transaction
"active" after the execution of *func* (and no longer the initial
transaction which might already have been committed/aborted by *func*)
(`#58 <https://github.com/zopefoundation/transaction/issues/58>`_).

It aborts the transaction now for all exceptions raised by *func* - even
if it is only an instance of `BaseException` but not of `Exception`,
such as e.g. a ``SystemExit`` or ``KeyboardInterupt`` exception.


2.4.0 (2018-10-23)
Expand Down
20 changes: 11 additions & 9 deletions transaction/tests/test__manager.py
Expand Up @@ -704,15 +704,17 @@ def run(self):
runner.join(1)

# The lack of the method below caused a test failure in one run
# -- maybe caused indirectly by the failure of another test
# Defining the methods below reduced the "test coverage". We
# therefore remove them again
# the preceeding test (maybe others as well) registers `self` as
# synchronizer; satisfy the `ISynchronizer` requirements
## def newTransaction(self, transaction):
## pass

## beforeCompletion = afterCompletion = newTransaction
# -- caused indirectly by the failure of another test (this
# indicates that the tests in this suite are not fully isolated).
# However, defining the methods below reduced the "test coverage"
# once the initial test failure has been fixed.
# We therefore comment them out.
## # the preceeding test (maybe others as well) registers `self` as
## # synchronizer; satisfy the `ISynchronizer` requirements
## def newTransaction(self, transaction):
## pass
##
## beforeCompletion = afterCompletion = newTransaction


class TestThreadTransactionManager(unittest.TestCase):
Expand Down

0 comments on commit 61a1168

Please sign in to comment.