New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction manager run problems #58
Labels
Comments
|
d-maurer
added a commit
that referenced
this issue
Apr 30, 2019
d-maurer
added a commit
that referenced
this issue
May 4, 2019
… reference to #58). Change comment formatting in the test suite.
d-maurer
added a commit
that referenced
this issue
May 6, 2019
d-maurer
added a commit
that referenced
this issue
May 6, 2019
… reference to #58). Change comment formatting in the test suite.
d-maurer
added a commit
that referenced
this issue
May 7, 2019
Fix transaction manager run problems #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the number of retries has been exceeded, we don't abort the transaction. We should always abort and then raise.
The
run
implementation doesn't account for application code creating new transactions. This is an important use case. Consider an application that catches errors, and needs to record information about the errors transactionally. In this case, the application aborts the current transaction, uses a new transaction to record some information, or otherwise recover. Therun
implementation should use the transaction manager methods to do it's work, rather than assuming it can interact with the initial transaction. Currently, an error is raised if the transaction changes.The text was updated successfully, but these errors were encountered: