Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy functionality from ITransactionDeprecated #89

Closed
jamadden opened this issue Dec 9, 2019 · 0 comments · Fixed by #90
Closed

Remove legacy functionality from ITransactionDeprecated #89

jamadden opened this issue Dec 9, 2019 · 0 comments · Fixed by #90

Comments

@jamadden
Copy link
Member

jamadden commented Dec 9, 2019

There's a bunch of compatibility code supporting the old Transaction.register and DataManager.prepare APIs. That code is either documented as deprecated, commented as deprecated, or not documented at all. It hasn't been the supported protocol since transaction became its own distribution.

Removing it doesn't break any ZODB tests (except tests that are explicitly using testing the legacy functions).
jamadden added a commit that referenced this issue Dec 9, 2019
@jamadden
Remove ITransactionDeprecated and supporting code.
097c1b6 
Fixes #89.

Has just enough documentation fixes from #88 to make the doctests pass on current versions of sphinx/docutils.
@jamadden jamadden mentioned this issue Dec 9, 2019
Merged
jamadden added a commit that referenced this issue Dec 9, 2019
@jamadden
Remove ITransactionDeprecated and supporting code.
4e7eb29 
Fixes #89.

Has just enough documentation fixes from #88 to make the doctests pass on current versions of sphinx/docutils.
@jamadden jamadden mentioned this issue Dec 11, 2019
Closed
jamadden added a commit that referenced this issue Dec 11, 2019
@jamadden
Remove ITransactionDeprecated and supporting code.
d501419 
Fixes #89.

Has just enough documentation fixes from #88 to make the doctests pass on current versions of sphinx/docutils.
@pyup-bot pyup-bot mentioned this issue Jun 30, 2020
Closed
@icemac icemac mentioned this issue Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ITransactionDeprecated and supporting code. zopefoundation/transaction
1 participant
@jamadden