Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation gardening. #88

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Documentation gardening. #88

merged 1 commit into from
Dec 11, 2019

Conversation

jamadden
Copy link
Member

@jamadden jamadden commented Dec 9, 2019

This was sparked because I noticed that the classes that were newly documented in #86 aren't actually showing up on transaction.readthedocs.io, despite the new build that occurred because of in #87. I didn't see anything in the logs, but we'll see what happens after this.

  • conf.py: Use default autodoc flags, and prepare for Sphinx 2.0.

  • conf.py: Read the correct version number for transaction.

  • conf.py: Add intersphinx mappings for stdlib and ZODB.

  • conf.py: Make the default role be object references, enabling IThing instead of :class:IThing for prettier docstrings.

  • interfaces.py: Cross references.

  • interfaces.py: ITransaction: Remove outdated docs about using a single transaction object more than one time. That doesn't work anymore.

  • interfaces.py: Simplify copied documentation, especially for the various ITransaction hook methods.

  • api.rst: DRY, use the default flags.

  • convenience.rst, integrations.rst: Fix compatibility with Sphinx 2 and straighten adornments

    Previously they raised "TypeError: '_traversal_list' object is not reversible"
    from sphinx.util.nodes line 151 apply_source_workaround.

- conf.py: Use default autodoc flags, and prepare for Sphinx 2.0.
- conf.py: Read the correct version number for transaction.
- conf.py: Add intersphinx mappings for stdlib and ZODB.
- conf.py: Make the default role be object references, enabling
   `IThing` instead of :class:`IThing` for prettier docstrings.
- interfaces.py: Cross references.
- interfaces.py: ITransaction: Remove outdated docs about using
   a single transaction object more than one time. That doesn't
   work anymore.
- interfaces.py: Simplify copied documentation, especially for
   the various ITransaction hook methods.
- convenience.rst, integrations.rst: Fix compatibility with Sphinx 2 and straighten adornments
   Previously they raised "TypeError: '_traversal_list' object is not reversible"
   from sphinx.util.nodes line 151 apply_source_workaround.
jamadden added a commit that referenced this pull request Dec 9, 2019
Fixes #89.

Has just enough documentation fixes from #88 to make the doctests pass on current versions of sphinx/docutils.
@jamadden jamadden added the docs Pertaining to documentation label Dec 9, 2019
jamadden added a commit that referenced this pull request Dec 9, 2019
Fixes #89.

Has just enough documentation fixes from #88 to make the doctests pass on current versions of sphinx/docutils.
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jamadden jamadden merged commit a47b6c7 into master Dec 11, 2019
@jamadden jamadden deleted the docs-take-2 branch December 11, 2019 08:28
@jamadden
Copy link
Member Author

Thank you!

jamadden added a commit that referenced this pull request Dec 11, 2019
Fixes #89.

Has just enough documentation fixes from #88 to make the doctests pass on current versions of sphinx/docutils.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Pertaining to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants