Only close our own opened files at go()

[rapto]

We should only close files we opened. The practical problem solved is using a Django response or IO as output file. I have added check for closing the xml file, as I suppose the problem may arise when using a stream as xml input file.

[regebro]

You are quite correct, but I implemented this with context managers.

Thanks!

[orainova-ingentics]

It seems like this issue is still present? @regebro could you please elaborate on your workaround to avoid closing files? Currently, we're unable to use the library unless I fork it to fix closing the external BytesIO. Shall I open a new issue, since @rapto's PR has not been merged?

Edit: while I'm still curious why it's not been fixed yet, and about regebro's own workaround, I'll provide my own wrapper, in case someone comes across this issue in the future and needs it working:
`

with BytesIO(dataRml) as inputRml:
... 
  with BytesIO() as resultPdf:
    self.rml2pdf(inputRml, resultPdf)
...

def rml2pdf(self, rml, pdf):

    root = etree.parse(rml).getroot()
    doc = document.Document(root)
    doc.filename = rml

    try:
        doc.process(pdf)
    except Exception as err:
        print("Pdf generator error: %s" % err)
        traceback.print_exc()

`

[rapto]

This (as current in master):

    if hasattr(xmlInputName, 'read'):
        # it is already a file-like object
        xmlFile = xmlInputName
        xmlInputName = 'input.pdf'
    else:
        with open(xmlInputName, 'rb') as xmlFile:
            return go(xmlFile, outputFileName, outDir, dtdDir)

works fine in my case

[regebro]

@orainova-ingentics A version with the changes has not been released, and it should be, that's correct.

My fix looks at the input, and if it's an open file, it does not open or close it. If it is a path it will open it with a context manager. That ensures that it is closed.

[regebro]

Version 4.3.0 has now been released.