Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning a new thread-local session on every web request call #22

Closed
wants to merge 1 commit into from
Closed

Returning a new thread-local session on every web request call #22

wants to merge 1 commit into from

Conversation

Buvi1234
Copy link

@Buvi1234 Buvi1234 commented Apr 3, 2024 •
edited by icemac

Fixes #21.

@icemac icemac requested a review from ale-rt April 4, 2024 06:26
@icemac
Copy link
Member

icemac commented Apr 4, 2024

@ale-rt I have no idea whether this change is a solution or creates new problems. GitHub suggested you as reviewer – do you know more or know who might know it?

ale-rt
ale-rt requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the PR I would get rid of self._session all together and make the session property return self._sessionmaker() directly.

Anyway this misses a changelog and the test should run.

@ale-rt
Copy link
Member

ale-rt commented Apr 4, 2024

Basically that would revert fb7d533#diff-db330870b3c724635c264a3b55db5b371bf48d1d03345c3df11178bba33c4442L105-L142
I do not remember why I did that in the first place.
Anyway, I am preparing a PR.

@ale-rt
Copy link
Member

ale-rt commented Apr 4, 2024 •
edited

Anyway, I am preparing a PR.

See #23

@icemac icemac mentioned this pull request Apr 9, 2024
Merged
@icemac icemac closed this in #23 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ale-rt ale-rt ale-rt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting connection busy issue on using latest version z3c.sqlalchemy
3 participants
@Buvi1234 @icemac @ale-rt