The session property returns a fresh session everytime it is invoked #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @Buvi1234 for finding this out! |
|
FYI the test run is here: https://github.com/zopefoundation/z3c.sqlalchemy/actions/runs/8551206228 IDK why the status is not reported. |
Pull Request Test Coverage Report for Build 8551206228Details
💛 - Coveralls |
icemac
approved these changes
Apr 9, 2024
icemac
deleted the
partially-revert-fb7d533aae819dc7e1aef8322c2f2d60a9a1b5d0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert commit fb7d533 which caused the sqlalchemy session instance to be persisted as an instance attribute. Fixes #21
Closes #22.