Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix the remaining failing test on Python 3.4
zdrun.py gets unhappy if it is spawned with no open file descriptors: it creates a master socket as fd 1 and then proptly os.dup2's it out of existence with the transcript pipe.
- Loading branch information
ff5287c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice diagnosis / fix!
ff5287c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, tests are still failing for me under Python 3.4.0:
ff5287c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the python3.4-pep446 branch? I get passing tests using
tox -e py34
withff5287c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crap! I though you had merged that to master. Can you re-push that branch (I think I deleted it)?
ff5287c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind -- looks like you saved me already :).
ff5287c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgedmin did we lose this fix? I can't find a PR (open or closed) that refers to this branch?
ff5287c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably committed it directly to master. It's right there in the current codebase: https://github.com/zopefoundation/zdaemon/blob/master/src/zdaemon/tests/parent.py#L40