-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to build on Python 3.2 on Windows: 'stackUnderflow' undefined #16
Comments
_pickle_27.c has a diff --git a/src/zodbpickle/_pickle_32.c b/src/zodbpickle/_pickle_32.c
index 2e559da..a5076bc 100644
--- a/src/zodbpickle/_pickle_32.c
+++ b/src/zodbpickle/_pickle_32.c
@@ -5615,7 +5615,7 @@ do_noload_setitems(UnpicklerObject *self, Py_ssize_t x)
Py_ssize_t len;
if (!( (len=Py_SIZE(self->stack)) >= x
- && x > 0 )) return stackUnderflow();
+ && x > 0 )) return stack_underflow();
dict=self->stack->data[x-1];
if (dict == Py_None) {
What's more worrying is that no tests fail when the C module cannot be built. This is why I'm not committing my fix yet. |
BTW on Linux the undefined name doesn't cause a compile-time error, it causes an import-time error:
|
Somebody ought to check whether this issue affects Python 3.3 and newer. |
AFAICS this was only affecting Python 3.2, which we're no longer supporting, so closing this bug. |
Here's an excerpt from the build log:
The text was updated successfully, but these errors were encountered: