Add tests with RelStorage and sqlite. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #30. - Refactor the tests to use a mixin class that defines the methods to create and cleanup storages. - Use unittest.skip decotarors instead of manually listing out the tests to run in test_suite(). This is simpler now that there are more test classes. - Add tests for history-free and history-preserving RelStorage storages. History preserving is tested locally, but will be skipped on CI because I haven't released RelStorage 3.3 yet. - Fix a test hygiene issue that caused subsequent tests to fail after test_skipped_types_are_left_untouched was run.
…rns. Make FileStorage its own mixin, and put everything in the single temp directory, which is automatically torn down.
mgedmin
approved these changes
Sep 1, 2020
| @@ -140,8 +143,7 @@ class OtherFactory(persistent.Persistent): | |||
| sys.modules['module2'].interfaces = sys.modules['module2.interfaces'] | |||
| sys.modules['module2.interfaces'].IOtherFactory = IOtherFactory | |||
|
|
|||
| self.tmphnd, self.dbfile = tempfile.mkstemp() | |||
| self.tmpblob = tempfile.mkdtemp() | |||
| self.temp_dir = tempfile.mkdtemp('.zodbupdate') | |||
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30.