Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.2 no longer includes mo files #17

Closed
wosc opened this issue Sep 6, 2022 · 3 comments · Fixed by #18
Closed

Release 4.2 no longer includes mo files #17

wosc opened this issue Sep 6, 2022 · 3 comments · Fixed by #18
Assignees

Comments

@wosc
Copy link
Contributor

wosc commented Sep 6, 2022

After #13 only includes po/pot in the release, causing the translations to not be available out-of-the-box anymore. Is this intentional? If yes, I'd appreciate a pointer on how consumers of this package are expected to use it now (compile to mo as part of our local application package release somehow?). Thanks!

@icemac
Copy link
Member

icemac commented Sep 6, 2022

See #6 (review) how to create the *.mo files on the fly.

I plan to add instructions to the README of the package and probably also get rid of the *.mo files in the repository. (They are compiled files like *.pyc ones which are also not in the repository.) See also #7.

@icemac icemac self-assigned this Sep 6, 2022
icemac pushed a commit that referenced this issue Sep 7, 2022
Fixes #7.

Document in the README how to generate `*.mo` files on the fly.

Fixes #17.
@wosc
Copy link
Contributor Author

wosc commented Sep 7, 2022

Thank you for pointing that out, I did indeed not know about the on-the-fly compile option in zope.i18n. I'm not sure I like it very much, either (for example: if the application runs in a container, it incurs the compile overhead, however minor, on each startup, even though the result cannot change as long as the package does not release a new version), but that might be my own problem to solve...

icemac pushed a commit that referenced this issue Sep 12, 2022
* Remove `*.mo` files from the repository. (Fixes #7.)
* Document in the README how to generate `*.mo` files on the fly. (Fixes #17.)
* Require zest.pocompile for releases to generate `*.mo` files during the release
@icemac
Copy link
Member

icemac commented Sep 12, 2022

Version https://pypi.org/project/zope.app.locales/4.3/ again contains *.mo files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants