-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.7 support #53
Conversation
@@ -6,6 +6,9 @@ matrix: | |||
- python: 3.4 | |||
- python: 3.5 | |||
- python: 3.6 | |||
- python: 3.7 | |||
dist: xenial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why specify dist
and sudo
for 3.7 when we aren't doing that for other Python versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because Python 3.7 does not work without those settings on Travis CI: travis-ci/travis-ci#9815
(Something about new OpenSSL version requirement that means 3.7 cannot be built on Ubuntu trusty, which is the default Travis CI image AFAIU. No clue why it fails without the sudo
bit, but that issue indicates that it's also required.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch. OK, I don't think we need to be the ones to debug ubuntu or travis issues, so... guess we can live with it. :-(
There's one test failure in proxy.rst:
I can reproduce it locally with |
ABCMeta._abc_invalidation_counter is no more. The test passes if we don't touch it, so we're all good? There are no more hidden caches we need to worry about? Anybody want to dig into this deeper?
ABCMeta._abc_invalidation_counter is still present on Python 3.7 when the pure-python _py_abc implementation is used (as opposed to the builtin _abc).
(Should I also bump the upcoming version number to 4.3.0?)