Add Python 3.7 support #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddrake
reviewed
Aug 8, 2018
| @@ -6,6 +6,9 @@ matrix: | |||
| - python: 3.4 | |||
| - python: 3.5 | |||
| - python: 3.6 | |||
| - python: 3.7 | |||
| dist: xenial | |||
There was a problem hiding this comment.
Why specify dist and sudo for 3.7 when we aren't doing that for other Python versions?
There was a problem hiding this comment.
Because Python 3.7 does not work without those settings on Travis CI: travis-ci/travis-ci#9815
(Something about new OpenSSL version requirement that means 3.7 cannot be built on Ubuntu trusty, which is the default Travis CI image AFAIU. No clue why it fails without the sudo bit, but that issue indicates that it's also required.)
There was a problem hiding this comment.
Ouch. OK, I don't think we need to be the ones to debug ubuntu or travis issues, so... guess we can live with it. :-(
|
There's one test failure in proxy.rst: I can reproduce it locally with |
ABCMeta._abc_invalidation_counter is no more. The test passes if we don't touch it, so we're all good? There are no more hidden caches we need to worry about? Anybody want to dig into this deeper?
ABCMeta._abc_invalidation_counter is still present on Python 3.7 when the pure-python _py_abc implementation is used (as opposed to the builtin _abc).
tseaver
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Should I also bump the upcoming version number to 4.3.0?)