ILocalSiteManager subs attribute keeps subsites referenced after deleting. #1
Assignees
Comments
|
I would expect there to be an event subscriber that removes local site registrations on object deletion events. If that's not the case, one should be added. |
icemac
pushed a commit
that referenced
this issue
Sep 9, 2020
… site manager. Fixes #1. The implementation is taken from https://github.com/zopefoundation/grokcore.site/blob/fc945c90c5093de8f7ff958cf498eb6305b9c068/src/grokcore/site/subscriber.py#L35-L46
icemac
pushed a commit
that referenced
this issue
Sep 10, 2020
…e manager (#14) Fixes #1. The implementation was originally taken from https://github.com/zopefoundation/grokcore.site/blob/fc945c90c5093de8f7ff958cf498eb6305b9c068/src/grokcore/site/subscriber.py#L35-L46 but changed in the review process of this PR. Co-authored-by: Jason Madden <jamadden@gmail.com>
icemac
pushed a commit
that referenced
this issue
Sep 10, 2020
This fixes a reference leak from a parent site manager. See `issue 1 <https://github.com/zopefoundation/zope.site/issues/1>`.
icemac
pushed a commit
that referenced
this issue
Sep 10, 2020
This fixes a reference leak from a parent site manager. See `issue 1 <https://github.com/zopefoundation/zope.site/issues/1>`.
icemac
pushed a commit
that referenced
this issue
Sep 10, 2020
This fixes a reference leak from a parent site manager. See `issue 1 <https://github.com/zopefoundation/zope.site/issues/1>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ILocalSiteManagersubs attribute keeps subsites referenced after deleting.That means you can delete the subsite but the whole will stay in the ZODB because of this attribute.
And that is BAD BAD BAD. Or do I have to "manually" kill that off when removing a subsite?
Copied from
https://bugs.launchpad.net/zope.site/+bug/659162
The text was updated successfully, but these errors were encountered: