Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap_pagination tag does not use Bootstrap 4 classes #20

Closed
AndrewKlopper opened this issue Sep 6, 2017 · 3 comments
Closed

bootstrap_pagination tag does not use Bootstrap 4 classes #20

AndrewKlopper opened this issue Sep 6, 2017 · 3 comments

Comments

@AndrewKlopper
Copy link

AndrewKlopper commented Sep 6, 2017 •
edited
Loading

The bootstrap_pagination tag does not not include the "page-item" class on "li" tags or the "page-link" class on "a" tags as required by Bootstrap 4. As a result, pagination links are unstyled.
@jieter
Copy link
Member

jieter commented Sep 6, 2017

@AndrewKlopper confirmed.

Are you able and willing to contribute a patch? Please open a pull request!

@jieter
Copy link
Member

jieter commented Sep 6, 2017

Ah, spoke to quick, there already is one

@jieter
Copy link
Member

jieter commented Sep 6, 2017

#19 is merged, adds this.

@jieter jieter closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieter @AndrewKlopper