Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release 1.1.0 #185

Merged
merged 5 commits into from Dec 7, 2019
Merged

Prepare release 1.1.0 #185

merged 5 commits into from Dec 7, 2019

Conversation

dyve
Copy link
Member

@dyve dyve commented Dec 6, 2019 •
edited

  • Update default Bootstrap to v4.3.1
  • Add support for Python 3.8, Django 3 and Django master
  • Switch to Django manage.py for test running
  • Update Makefile commands
  • Update tox configuration
  • Use correct license (BSD-3-Clause)
  • Fix typo's in docstrings
  • Update Travis configuration
  • Drop MANIFEST.in, use setuptools_scm
  • Stop using _version.py, use git tags for versioning
  • Fixed issues with labels and input (The 1.0.1 release broke a test for us #174 and Do not assume inputs to be inside labels #181)

@dyve
Prepare release 1.1.0
23fdb82 
- Update default Bootstrap to v4.3.1
- Add support for Python 3.8, Django 3 and Django master
- Switch to Django `manage.py` for test running
- Update Makefile commands
- Update tox configuration
- Use correct license (BSD-3-Clause)
- Fix typo's in docstrings
- Update Travis configuration
- Drop MANIFEST.in, use setuptools_scm
- Stop using _version.py, use git tags for versioning
- Fixed issues with labels and input (#174 and #181)
@dyve dyve requested a review from jieter December 6, 2019 07:53
jieter
jieter reviewed Dec 6, 2019
View reviewed changes
Copy link
Member

@jieter jieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments.

Mixing the bugfixing with CI/release cleanup did make the review a bit chaotic though...

CONTRIBUTING.rst Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
jieter
jieter approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@jieter jieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dyve dyve merged commit bb845a4 into master Dec 7, 2019
@dyve dyve deleted the update-tox-makefile branch December 9, 2019 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieter jieter jieter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dyve @jieter