Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In some scenarios prefix needs to be ignored when wrapping DOI #127

Closed
tnajdek opened this issue Oct 29, 2021 · 0 comments · Fixed by #132
Closed

In some scenarios prefix needs to be ignored when wrapping DOI #127

tnajdek opened this issue Oct 29, 2021 · 0 comments · Fixed by #132
Labels
A-core Area: affects all builds of citeproc-rs

Comments

@tnajdek
Copy link
Member

tnajdek commented Oct 29, 2021

After #124, with the new link_anchors set to true, for the following CSL (copied from MLA):

<text variable="DOI" prefix="https://doi.org/"/>

The following HTML is produced:

https://doi.org/<a href="https://doi.org/VAR">https://doi.org/VAR</a>

https://doi.org/ part of the prefix shouldn't be used here as it already appears as part of the URL.

Related: #116
@tnajdek tnajdek mentioned this issue Oct 29, 2021
Merged
@cormacrelf cormacrelf added the A-core Area: affects all builds of citeproc-rs label Oct 30, 2021
cormacrelf added a commit that referenced this issue Oct 30, 2021
@cormacrelf
Merge pull request #128 from tnajdek/doi-https-prefix
404d2bd 
Test case for #127
@cormacrelf cormacrelf mentioned this issue Oct 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-core Area: affects all builds of citeproc-rs
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix doi urls in prefix duplication, and pmids/pmcids zotero/citeproc-rs
2 participants
@tnajdek @cormacrelf