Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an error on unrecognised output format (JS) #107

Merged
merged 3 commits into from
Apr 21, 2021
Merged

Return an error on unrecognised output format (JS) #107

merged 3 commits into from
Apr 21, 2021

Conversation

cormacrelf
Copy link
Collaborator

Fixes #91, which was never really a bug in the formatting code.

  • add test for built_cluster_preview format-changing
    • This already passed. Turns out the code was pretty much correct anyway.
  • add structure to js-tests, and add an unrecognised output format test to JS
  • make previewCitationCluster fail on unknown output format

@cormacrelf
Copy link
Collaborator Author

The failures are due to a GitHub Actions outage. Each of the 3 parts have succeeded in at least one workflow run!

@cormacrelf cormacrelf merged commit 0164b40 into master Apr 21, 2021
@cormacrelf cormacrelf added the A-wasm Area: wasm package on npm label Sep 5, 2021
@cormacrelf cormacrelf deleted the issue-91 branch September 5, 2021 13:14
@cormacrelf cormacrelf changed the title Error on unrecognised output format (JS) Return an error on unrecognised output format (JS) Sep 5, 2021
@cormacrelf cormacrelf added the enhancement New feature or request label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-wasm Area: wasm package on npm enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plaintext output of citations does not handle unicode characters properly
1 participant
@cormacrelf