Fix npm publishing breakage due to wasm-opt segfault #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
O3 is faster; O4 does not produce significantly smaller binaries. However, this does not solve the problem of wasm-opt segfaulting on CI.
This disables incremental compilation: see https://blog.rust-lang.org/2021/05/10/Rust-1.52.1.html (i.e. incremental within a crate (= within a compilation unit))
cormacrelf
added
A-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
Uses a forked wasm-pack that doesn't use a pinned old wasm-opt version. This was necessary because wasm-opt actually just started segfaulting. I didn't find out what version wasm-pack has it pinned at (from sometime in 2019? 2020?), but downloading wasm-opt from binaryen's GitHub Releases
version_101works.Also switches back to -O3 because it's a lot faster to run wasm-opt and the binary is not much bigger.