Fix "line-spacing" attribute on <bibliography> in CSL is ignored #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cormacrelf
added
A-core
|
Anything holding this up? This seems like a blocker. |
|
After all that, it turns out I can't test that the new post-ci.yml workflow works for non-collaborators, if you re-run the checks GH just uses the version that was in place last time they were run. |
|
Thanks @tnajdek 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where bibliography renders with incorrect line spacing.
Struct
style::Bibliographyusedline-spaces, however it should beline-spacingaccording to the spec.