Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplement name parsing #139

Merged
merged 4 commits into from
Dec 1, 2021
Merged

reimplement name parsing #139

merged 4 commits into from
Dec 1, 2021

Conversation

cormacrelf
Copy link
Collaborator

@cormacrelf cormacrelf commented Dec 1, 2021

This used to use code from citeproc-js, licensed under the Common Public Attribution License, so compliant users of citeproc-rs had to credit Frank, for the small amount of code here and nothing else. It's been a year or two since I've been over it, so I deleted the parts I took, and wrote it again from first principles. It turned out a little bit simpler in general, using just straight ^ and $-based regexes with repetition for given names and last names, rather than the one-particle-at-a-time + given-names-get-reversed strategy of Frank's version.

Also adds support for the using strings and numbers as fuzzy JS-style booleans on the static-particles JSON input.

This was used under a license where you had to
credit Frank (CPAL). Not that that's so bad, it's
just a complicated licensing requirement.
@cormacrelf cormacrelf merged commit 792c0e1 into master Dec 1, 2021
@cormacrelf cormacrelf deleted the reimplement-name-parsing branch December 1, 2021 14:03
@cormacrelf cormacrelf added A-core Area: affects all builds of citeproc-rs A-internals Area: internal implementation details labels Dec 1, 2021
@fbennett
Copy link

fbennett commented Dec 2, 2021

(For what it's worth, I wouldn't have cared about licensing whatnot whatnot.)

@cormacrelf
Copy link
Collaborator Author

I didn't think you would have, but people (esp. companies) get antsy about the littlest things when they're considering whether to use an open source work. And easier to just write it again than kick up a fuss :)

@fbennett
Copy link

fbennett commented Dec 2, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: affects all builds of citeproc-rs A-internals Area: internal implementation details
Development

Successfully merging this pull request may close these issues.

None yet

2 participants