previewCitationCluster => previewCluster #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previewCitationCluster's args are as they used to be, passing cites in as an array. previewCluster supports the full PreviewCluster object.
cormacrelf
added
A-wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
The overall effect of these commits is to
@deprecatedJSDoc tag, so TypeScript editors should pick this up and show a warning on use)previewClusterthat changes the first argument to use an id-less Cluster object, on which you can put a cluster mode, and any future cluster options.formatargument optional, because recent wasm-bindgen can do this.