-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncited Items API #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cites. The bib order is per the spec, a long-standing TODO in year_suffixes(). Using ghost cites for every single reference is a new tactic, to avoid the following case where @A and @b need a year suffix but @c is different: uncited: @b, @c --- @A @A @A Here, the second @A is ibid, and only renders "ibid.". However, this cite will be accepted by all three DFAs. So previously, the bibliography would have a year suffix added to all three entries, simply because an ibid cite in the document, not expected to be able to be disambiguated, matched each. New code only using ghost cites (which are always First) means that these suffixes are based on the most ideal representation of the reference.
cormacrelf
added
A-wasm
Area: wasm package on npm
A-core
Area: affects all builds of citeproc-rs
enhancement
New feature or request
A-crates/citeproc
Area: citeproc crate
A-crates/csl
Area: csl crate
labels
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: affects all builds of citeproc-rs
A-crates/citeproc
Area: citeproc crate
A-crates/csl
Area: csl crate
A-wasm
Area: wasm package on npm
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sum:
If a reference, known to the driver, is not cited in any of the clusters in the document, it can still be included in the bibliography if it matches the filter set by
includeUncited()
.This has been tested especially in the context of disambiguating using those uncited items. It lacks an actual test suite to confirm that, but the matter is almost entirely whether those items participate or not.
Also:
can be different from cited order
groups. Because "ibid" references can match more items' DFAs than they
should. See that "Alloc year suffixes" commit for details.