Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unclear setReferences, replace with insertReferences + resetReferences #69

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Remove unclear setReferences, replace with insertReferences + resetReferences #69

merged 2 commits into from
Sep 18, 2020

Conversation

cormacrelf
Copy link
Collaborator

This was started in #68, it turns out. The terminology is updated to be
consistent, especially important for uncited items:

  • Reset will wipe all refs, replace the list.
  • Insert will overwrite if necessary and otherwise insert.

@cormacrelf cormacrelf merged commit 7bb4807 into master Sep 18, 2020
@cormacrelf cormacrelf deleted the remove-setReferences branch September 18, 2020 22:56
@cormacrelf cormacrelf added A-wasm Area: wasm package on npm breaking Breaking change labels Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-wasm Area: wasm package on npm breaking Breaking change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cormacrelf