Don't exclude the no-modules target from NPM builds #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...without saying 'recursive use of an object detected ... that would lead to unsafe aliasing in rust' due to wasm-bindgen runtime checks. For whatever reason the runtime isn't releasing its Rc lock on Driver, but this change is fine since we already have an Rc over the engine.
The npmrc has a precedence list, so >> was incorrect.
cormacrelf
added
A-wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The no-modules build wasn't listed in the package.json's
filesmanifest, so it never got published. That was a bit of an oversight. Now you should be able to use it as described in the README.It also includes some debug info in the published releases, so any stack traces from any panics that occur aren't nonsense, which previously I hadn't been able to get through wasm-opt.
&mut selffrom wasm Driver methods so it survives a panic