Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubikat (Aleph) Fails to Import #2255

Closed
adam3smith opened this issue Sep 29, 2020 · 4 comments · Fixed by #2378
Closed

Kubikat (Aleph) Fails to Import #2255

adam3smith opened this issue Sep 29, 2020 · 4 comments · Fixed by #2378

Comments

@adam3smith
Copy link
Collaborator

User reports this used to work and MARC is present on the page:
Reported: https://forums.zotero.org/discussion/85358/issue-with-translator-kubikat#latest
Example: https://forums.zotero.org/discussion/85358/issue-with-translator-kubikat#latest

@AbeJellinek
Copy link
Member

The link in the report fails to import, but the issue seems to be that detectWeb should fail and doWeb should never run; it's the library's homepage, not an importable catalog record. Actual books (example) import fine. I'll see if there's a decent heuristic we can use to make sure detectWeb returns false on non-record pages.

@AbeJellinek
Copy link
Member

(It's possible that the link died and it's showing me the homepage as a fallback, but I can't find an archived version of the page to verify that.)

@adam3smith
Copy link
Collaborator Author

adam3smith commented May 20, 2021

Sorry, I meant to put a permalink there and just duplicated the link to the forum. I have other examples failing, e.g. https://aleph.mpg.de/F?func=direct&doc_number=000000037&local_base=mpg01 -- looks like something wrong with how the MARC is parsed in?
(aleph catalogs display results with session IDs, so those wouldn't typically archive)

AbeJellinek added a commit to AbeJellinek/translators that referenced this issue May 20, 2021
@AbeJellinek
Copy link
Member

Oh, OK, I see. It looks like the MARC parser is doing the right thing, assuming that it's passed MARC. But that record is MAB! There's no obvious way to tell whether a record is MARC or MAB from the page, so I'll make it fall back on our MAB2 translator if MARC fails.

AbeJellinek added a commit to AbeJellinek/translators that referenced this issue May 20, 2021
Fixes zotero#2255. This ended up being simpler than I thought it would be: the
translator already understood that some Aleph records are in MAB2
format, but the URL regex was too restrictive.
AbeJellinek added a commit to AbeJellinek/translators that referenced this issue May 21, 2021
Fixes zotero#2255. This ended up being simpler than I thought it would be: the
translator already understood that some Aleph records are in MAB2
format, but the URL regex was too restrictive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants