Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aleph: Allow missing slash when detecting MAB2 URL; linting #2378

Merged
merged 2 commits into from
May 21, 2021
Merged

Aleph: Allow missing slash when detecting MAB2 URL; linting #2378

merged 2 commits into from
May 21, 2021

Conversation

AbeJellinek
Copy link
Member

Fixes #2255.

@dstillman
Copy link
Member

Looks good. You can squash the last two commits into the first and then merge.

@AbeJellinek
Aleph: Allow missing slash when detecting MAB2 URL
6fad5b2 
Fixes zotero#2255. This ended up being simpler than I thought it would be: the
translator already understood that some Aleph records are in MAB2
format, but the URL regex was too restrictive.
@AbeJellinek
Aleph: Linting
7dc677b
@AbeJellinek AbeJellinek merged commit db0648b into zotero:master May 21, 2021
@AbeJellinek AbeJellinek deleted the aleph branch May 21, 2021 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstillman dstillman dstillman left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubikat (Aleph) Fails to Import
2 participants
@AbeJellinek @dstillman