-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSF Preprint: fix broken detection for multiple search results; unify search-result & individual-article scraping #3162
Open
zoe-translates
wants to merge
7
commits into
zotero:master
Choose a base branch
from
zoe-translates:osf-preprint-discovery-search
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
73bc386
OSF: Update search page URLs/selectors; be less eager in monitoring DOM
zoe-translates 08635c5
OSF: Unify the scraping of search results and individual preprints
zoe-translates 76929f9
OSF: Add Accept: header to API request just in case
zoe-translates dce6216
OSF Preprints: Prevent passing nullish value into ZU.unescapeHTML()
zoe-translates 78fbbb5
OSF Preprints: Update metadata fields for attachment and authors
zoe-translates 185e3b1
OSF Preprints: Simplify target/identification regexes
zoe-translates 1351404
OSF Preprints: Bump minVersion to 6.0, unconditionally support preprint
zoe-translates File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure anyone actually calls it this - their site only uses "OSF" and I had no idea that's what it stands for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was caused by the data source. In our code we have
and it appears that the exact phrasing used by the OSF to describe itself has changed to this (
"Open Science Framework"
)I think the original intent behind setting
publisher
/repository
from the embeddedprovider
data was that some OSF projects (psyarxiv, for example) identify themselves programmatically in this way. Therefore we could get the more specific repository name (e.g. psyarxiv) as opposed to the umbrella OSF.