Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French plural definite article to cite key banned title words #3283

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

larsgw
Copy link
Contributor

@larsgw larsgw commented Mar 25, 2024

Not sure if this was excluded on purpose, but if not 'les' was missing from the list. E.g. in

@article{vandel_les_1958,
	title = {Les activités du Laboratoire souterrain du C.N.R.S. à Moulis},
	issn = {0369-3392},
	url = {https://cnum.cnam.fr/pgi/fpage.php?4KY28.153/284/100/527/5/513},
	pages = {280--282},
	number = {3279},
	journaltitle = {La Nature},
	author = {Vandel, Albert},
	date = {1958},
	langid = {french},
}

I would rather have

@article{vandel_activites_1958,
...

@AbeJellinek
Copy link
Member

  • Need to update lastUpdated (use Scaffold!)
  • Can make the same change in BibTeX.js (line 1245)

Otherwise looks good!

@AbeJellinek AbeJellinek merged commit a3591e1 into zotero:master Mar 25, 2024
1 check failed
@AbeJellinek
Copy link
Member

Thank you!

@larsgw
Copy link
Contributor Author

larsgw commented Mar 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants