vpat 40/41: style editor aria fixes #4022
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaevbog
force-pushed
the
vpat_40
branch
2 times, most recently
from
4e92d0b
to
77636a3
Compare
- linked all labels to their respective inputs so they are announced by screen readers - added aria-labels for the actual editor and preview iframes - locator type and locator input are assigned aria-labels - added visible labels to citation style and language menus, since vpat 40 specifically asks for visible labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vpat 40 says "These elements should have descriptive, persistent, visible labels and descriptive names that include their labels." referring to all the inputs of the style editor. Per #4039, the locator type and locator input are left as is but there are aria-labels set on them so that they are announced by the screen reader.
I did add visible labels for the "Language" and the "Citation Style" because I feel like it doesn't hurt here?