Don't return incomplete documents for HTTP.processDocuments #666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adam3smith emailed me about an issue with Aleph translator. On https://aleph.univie.ac.at a
ZU.processDocuments
call to retrieve MARC metadata was returning an incomplete page (only a few META elements from the HEAD). The processDocuments call was accompanied by the following message in the Browser console:So, what was happening was that the page was being loaded, the loading was stopped (firing a
pageshow
event, but not theload
event), and Zotero was returning the incomplete document to translator (just past the META element with charset declaration).This patch takes advantage to the
load
event not being fired in these cases to detect incomplete page loads. However, as commented here the same behavior is obtained for network errors (don't think these were being handled anyway), so we introduce some additional checks for those cases.