Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You should not be able to set an unsupported language in the URL #258

Closed
arjan opened this issue Nov 10, 2011 · 1 comment
Closed

You should not be able to set an unsupported language in the URL #258

arjan opened this issue Nov 10, 2011 · 1 comment
Milestone

Comments

@arjan
Copy link
Member

arjan commented Nov 10, 2011

http://127.0.0.1:8000/ru/article/316/welcome-to-zotonic-0-8-dev
http://127.0.0.1:8000/ru/

These urls work although I do not have russian enabled.

Furthermore: this URL crashes my dispatcher:

http://127.0.0.1:8000/ru

(e.g. without the slash). Isn't the dispatcher supervised??

=ERROR REPORT==== 10-Nov-2011::08:28:05 ===
** Generic server z_sites_dispatcher terminating 
** Last message in was {dispatch,"127.0.0.1:8000","/ru",
                        {wm_reqdata,#Port<0.15908>,
                         {dict,0,16,16,8,80,48,
                          {[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]},
                          {{[],[],[],[],[],[],[],[],[],[],[],[],[],[],[],[]}}},
                         undefined,"127.0.0.1",undefined,
                         {wm_log_data,1001320910085019087,undefined,
                          {1320,910085,19136},
                          'GET',
                          {8,
                           {"host",
                            {'Host',"127.0.0.1:8000"},
                            {"accept",
                             {'Accept',
                              "text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8"},
                             nil,
                             {"accept-language",
                              {'Accept-Language',
                               "en-US,en;q=0.9,en-gb;q=0.8,nl-NL;q=0.7,nl;q=0.6,fr-FR;q=0.4,fr;q=0.3,pl-PL;q=0.2,pl;q=0.1"},
                              {"accept-encoding",
                               {'Accept-Encoding',"gzip, deflate"},
                               {"accept-charset",
                                {'Accept-Charset',
                                 "ISO-8859-1,utf-8;q=0.7,*;q=0.7"},
                                nil,nil},
                               nil},
                              {"connection",
mworrell added a commit that referenced this issue Nov 10, 2011
Suppress language codes in URL when no languages enabled.
Refers to issue #258.
@mworrell
Copy link
Member

The dispatcher is supervised by the top level supervisor.

We might want to split the dispatcher in a site-lookup and url dispatcher.
Which we can easily do as we maintain our own fork of webmachine.

mworrell added a commit that referenced this issue Nov 10, 2011
rpip pushed a commit to rpip/zotonic that referenced this issue Aug 12, 2013
Suppress language codes in URL when no languages enabled.
Refers to issue zotonic#258.
rpip pushed a commit to rpip/zotonic that referenced this issue Aug 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants