fix: UI titles and message consistency #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Balhar <jakub@balhar.net>
Add title explaining the state Signed-off-by: Jakub Balhar <jakub@balhar.net>
|
@dkelosky Can you please help me refine the messages that should be shown as titles?
|
|
@dkelosky Is there any update from your side on the messaging or should we rather integrate this change and then take a look on further improvements later? |
|
Sorry for the delay - I reached out to some UX/UI friends for help. I will post back after getting their help. There were issues:
|
|
This PR solves only the first and third issue, the rest isn't touched by this PR. |
|
@dkelosky Any update? |
|
No updated - I engaged a friend (internally) to get some input. Will update back here once I get a response. |
Signed-off-by: Andrew Jandacek <andrew.jandacek@broadcom.com>
|
Shobhajayanna
pushed a commit
that referenced
this pull request
Jun 19, 2024
Signed-off-by: sj895092 <shobhackm9@gmail.com>
10 tasks
Shobhajayanna
added a commit
that referenced
this pull request
Jun 20, 2024
* fix: UI titles and message consistency (#3502) Signed-off-by: sj895092 <shobhackm9@gmail.com> * add bootRun debug default options (#3595) Signed-off-by: sj895092 <shobhackm9@gmail.com> * attempt at fixing flaky test (#3596) Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> Co-authored-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * update working dir in bootrun task (#3602) Signed-off-by: sj895092 <shobhackm9@gmail.com> * removed metrics service related test Signed-off-by: sj895092 <shobhackm9@gmail.com> * chore: protect conformance endpoints and add them to Swagger (#3604) * protect endpoints Signed-off-by: at670475 <andrea.tabone@broadcom.com> * add conformance to swagger Signed-off-by: at670475 <andrea.tabone@broadcom.com> * add test Signed-off-by: at670475 <andrea.tabone@broadcom.com> --------- Signed-off-by: at670475 <andrea.tabone@broadcom.com> * chore: protect conformance endpoints and add them to Swagger (#3604) * protect endpoints Signed-off-by: at670475 <andrea.tabone@broadcom.com> * add conformance to swagger Signed-off-by: at670475 <andrea.tabone@broadcom.com> * add test Signed-off-by: at670475 <andrea.tabone@broadcom.com> --------- Signed-off-by: at670475 <andrea.tabone@broadcom.com> * removing metric service reference Signed-off-by: sj895092 <shobhackm9@gmail.com> * removing gateway changes from v2 cherry pick Signed-off-by: sj895092 <shobhackm9@gmail.com> * reverting back changes in gateway service Signed-off-by: sj895092 <shobhackm9@gmail.com> * reverting back changes in gateway service Signed-off-by: sj895092 <shobhackm9@gmail.com> * reverting back conformance endpoint validation changes Signed-off-by: sj895092 <shobhackm9@gmail.com> * reverting back conformance endpoint validation changes Signed-off-by: sj895092 <shobhackm9@gmail.com> --------- Signed-off-by: sj895092 <shobhackm9@gmail.com> Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> Signed-off-by: at670475 <andrea.tabone@broadcom.com> Co-authored-by: Jakub Balhar <jakub@balhar.net> Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com> Co-authored-by: Pablo Hernán Carle <pablo.carle@broadcom.com> Co-authored-by: Andrea Tabone <39694626+taban03@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the messages consistent
Add UI titles explaining error, warning and success.
Linked to #3458 and #3456
Type of change
Checklist:
For more details about how should the code look like read the Contributing guideline