This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
43 apiml integration #104
Merged
43 apiml integration #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request(). Compiles and a sanity test works ok. Signed-off-by: Gene Johnston <Eugene.Johnston@ca.com>
Signed-off-by: ChrisBoehmCA <Christopher.Boehm@ca.com>
…nd end with a slash (or not). Also ensure that no leading or trailing spaces are included. Signed-off-by: Gene Johnston <Eugene.Johnston@ca.com>
Signed-off-by: ChrisBoehmCA <Christopher.Boehm@ca.com>
Signed-off-by: Gene Johnston <Eugene.Johnston@ca.com>
Signed-off-by: Jason <jason.tucker@ca.com>
Signed-off-by: Jason <jason.tucker@ca.com>
… - tests will fail Signed-off-by: Jason <jason.tucker@ca.com>
Signed-off-by: Jason <jason.tucker@ca.com>
Signed-off-by: Jason <jason.tucker@ca.com>
….com/zowe/imperative into 43_APIML_integration_
Signed-off-by: Jason <jason.tucker@ca.com>
…ative into 43_APIML_integration_
Signed-off-by: Jason <jason.tucker@ca.com>
Signed-off-by: Jason <jason.tucker@ca.com>
ghost
assigned 
ChrisBoehmCA
approved these changes
Nov 6, 2018
| "\nResource: " + finalError.resource + | ||
| "\nRequest: " + finalError.request + | ||
| "\nHeaders: " + headerDetails + | ||
| "\nPayload: " + payloadDetails; |
There was a problem hiding this comment.
This increased amount of information should hopefully be helpful to the user 👍
| * @type {string} | ||
| * @memberof ISession | ||
| */ | ||
| basePath?: string; |
There was a problem hiding this comment.
Nice thorough explanation of the concept of base path 👍
| @@ -185,17 +188,11 @@ export abstract class AbstractRestClient { | |||
| * Invoke any onError method whenever an error occurs on writing | |||
| */ | |||
| clientRequest.on("error", (errorResponse: any) => { | |||
| let impError: IImperativeError = { | |||
| reject(this.populateError({ | |||
There was a problem hiding this comment.
Cool that we now get more details in the case of client request errors
| @@ -522,7 +522,7 @@ export class CommandProcessor { | |||
| args._ = commandArguments._; | |||
|
|
|||
| // Log for debugging | |||
| this.log.debug(`Full argument object constructed:\n${inspect(args)}`); | |||
| this.log.trace(`Full argument object constructed:\n${inspect(args)}`); | |||
There was a problem hiding this comment.
Thanks for fixing this to not output password populated into the arguments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements the ability to specify "basePath" in the rest client session object. See the Swagger doc for details on "base path".
In summary, the "base path" is used/configured by API mediation layers and API Gateways to identify a service (and versioning).
Directly to the service:
https://host:port/pets
Gateway:
https://host:port/api/v1/pet_service/pets
In the above example,
api/v1/pet_servicewould be the "base path".CLI implementations which perform HTTP/REST calls can take advantage of this capability in order to be simultaneously compatible with a Gateway and going directly to a service.
Additional Improvements
Adds additional fields/properties to the rest client error for debugging/diagnostics. The additional fields are also formatted into a printable error response (found in the
additionalDetailsproperty of theImperativeError) and automatically formatted/surface if a RestClientError is thrown from a handler and caught by the Imperative command processor (normal error handling for command handlers).