-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Installation Stage + On click Navigation in Stepper + Progress Management #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakshibobade21
requested review from
timgerstel,
1000TurquoisePogs and
DivergentEuropeans
January 19, 2024 14:14
… review installation stage
1000TurquoisePogs
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was shown this code and there were follow-up actions that are now resolved so approved.
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
…re/review Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
DivergentEuropeans
approved these changes
Jan 26, 2024
Added a couple small stuff & merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implemented a feature where users can navigate directly to any stage in the Stepper and Sub-stepper by clicking on the respective stage
Enable navigation to the next stage only if all the required previous stages are completed successfully
Keep track of the completion of each stage.
3)If the user revisits the 'Connection' step and does not modify any attributes (e.g., host, port), then need not validate the connection again. Enable continue to next step directly
In the 'Planning' stage do not validate the JCL again if it is not updated. Similarly, if the locations are validated and the form is not updated do not validate the locations again. Enable continue to the next step directly
In every step revalidate everything if the stage is revisited and updated
Add the appropriate icons for each stage in stepper and substepper - Completed/Skipped/Not Visited. And change the icons dynamically when the state of the stage changes
Added a new stage "Review Installation"
This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zen/issues if any]
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments