Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Installation Stage + On click Navigation in Stepper + Progress Management #100

Merged
merged 18 commits into from
Jan 29, 2024

Conversation

sakshibobade21
Copy link
Contributor

@sakshibobade21 sakshibobade21 commented Jan 18, 2024

Proposed changes

  1. Implemented a feature where users can navigate directly to any stage in the Stepper and Sub-stepper by clicking on the respective stage

  2. Enable navigation to the next stage only if all the required previous stages are completed successfully

  3. Keep track of the completion of each stage.

3)If the user revisits the 'Connection' step and does not modify any attributes (e.g., host, port), then need not validate the connection again. Enable continue to next step directly

  1. In the 'Planning' stage do not validate the JCL again if it is not updated. Similarly, if the locations are validated and the form is not updated do not validate the locations again. Enable continue to the next step directly

  2. In every step revalidate everything if the stage is revisited and updated

  3. Add the appropriate icons for each stage in stepper and substepper - Completed/Skipped/Not Visited. And change the icons dynamically when the state of the stage changes

  4. Added a new stage "Review Installation"

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zen/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets a "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was shown this code and there were follow-up actions that are now resolved so approved.

@DivergentEuropeans
Copy link
Member

Added a couple small stuff & merging

@DivergentEuropeans DivergentEuropeans merged commit 038df23 into v2.x/staging Jan 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants