Regression fixes for 1st Release #218
Conversation
| @@ -203,7 +203,7 @@ const Home = () => { | |||
| setIsNewInstallation(true); | |||
| } else { | |||
| const data: ActiveState = unflatten(JSON.parse(lastInstallation)); | |||
| setIsNewInstallation(false); | |||
| setIsNewInstallation(!(data && data.lastActiveDate)); | |||
There was a problem hiding this comment.
I changed this line because quite frequently I would have a previously saved installation not show the resume button due to lastActiveDate being missing. Please fix the root cause instead (lastActiveDate not always being set properly.
There was a problem hiding this comment.
Never encountered an issue where - "resume button not showing sometimes when a previous installation does exist"
Confirmed this with Himani.
The previous date is always saved in the activeStage object, except for the home page where this behavior is intentional.
| @@ -46,6 +46,9 @@ const EditorDialog = ({contentType, isEditorVisible, toggleEditorVisibility, onC | |||
| /* TODO: Should use an array for the Store to house separate outputs (Security vs Certificates for example) */ | |||
| if(isEditorVisible) { | |||
| if(contentType == 'yaml') { | |||
| if (setupYaml?.installationArgs) { | |||
There was a problem hiding this comment.
This second delete is unnecessary, remove this and leave the other one
There was a problem hiding this comment.
How is this unnecessary?
There was a problem hiding this comment.
Because its redundant you only need the other delete
Proposed changes
This PR fixes the regressions:
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments