Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conditionally used middleware to add no-caching headers for secure APIs #49

Merged
merged 4 commits into from
Jan 11, 2019

Conversation

1000TurquoisePogs
Copy link
Member

Resolves https://github.com/zowe/zlux-proxy-server/issues/36
This adds headers to all dataservice calls (unless opt-out at service level or individual call level) which instructs browsers not to cache a response. This is useful for sensitive information or calls that have no need to be cached.

Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com

…ure APIs

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
@1000TurquoisePogs 1000TurquoisePogs requested a review from a team January 3, 2019 21:49
@ghost ghost added the review label Jan 3, 2019
@1000TurquoisePogs
Copy link
Member Author

Note that the "service" object passed through this section of the code is such that the properties of import services are always the original service that was imported. So, an import can not decide to have different caching behavior from the original service for example.

@1000TurquoisePogs 1000TurquoisePogs merged commit c4a4063 into zowe:master Jan 11, 2019
@ghost ghost removed the review label Jan 11, 2019
@1000TurquoisePogs 1000TurquoisePogs deleted the feature/ssl-nocache branch February 6, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants