Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload dataset using Buffer #152

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Conversation

std4lqi
Copy link
Collaborator

@std4lqi std4lqi commented Feb 1, 2024

What It Does
Upload dataset using Buffer, instead of string. Fix zowe/zowe-explorer-vscode#2533

How to Test
On Windows, upload a text data with // at the first line, as follows. It's expected to be saved in dataset successfully.

// abc

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9497b0f) 73.04% compared to head (5435aea) 73.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   73.04%   73.04%           
=======================================
  Files          80       80           
  Lines         983      983           
  Branches      127      128    +1     
=======================================
  Hits          718      718           
+ Misses        265      244   -21     
- Partials        0       21   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
@std4lqi std4lqi force-pushed the upload-text-dataset-wuth-buffer branch from c2b12d9 to fb672b3 Compare February 2, 2024 07:43
Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very obscure issue indeed 🤯

Thanks for fixing! 😋

Here is a VSIX (with this branch bundled in) in case you want to test it out.
https://ent.box.com/s/2u10v45jyq1nia2fstj7zczmhuj2au0c

Please keep in mind that you may need to delete any cached data related to FTP in %userprofile%/.vscode/extensions/ and %appdata%/Code/CachedXYZ (kudos to @traeok for that)

@zFernand0 zFernand0 merged commit 99f428d into master Feb 9, 2024
17 checks passed
@zFernand0 zFernand0 deleted the upload-text-dataset-wuth-buffer branch February 9, 2024 20:11
Copy link

github-actions bot commented Feb 9, 2024

Release succeeded for the master branch. 🎉

The following packages have been published:

  • npm: @zowe/zos-ftp-for-zowe-cli@2.1.8

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Members aren't saved, message "Saving data set..." but nothing happens and never ends.
4 participants