-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload dataset using Buffer #152
Conversation
Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 73.04% 73.04%
=======================================
Files 80 80
Lines 983 983
Branches 127 128 +1
=======================================
Hits 718 718
+ Misses 265 244 -21
- Partials 0 21 +21 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
c2b12d9
to
fb672b3
Compare
Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very obscure issue indeed 🤯
Thanks for fixing! 😋
Here is a VSIX (with this branch bundled in) in case you want to test it out.
https://ent.box.com/s/2u10v45jyq1nia2fstj7zczmhuj2au0c
Please keep in mind that you may need to delete any cached data related to FTP in %userprofile%/.vscode/extensions/
and %appdata%/Code/CachedXYZ
(kudos to @traeok for that)
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Upload dataset using Buffer, instead of string. Fix zowe/zowe-explorer-vscode#2533
How to Test
On Windows, upload a text data with
//
at the first line, as follows. It's expected to be saved in dataset successfully.Review Checklist
I certify that I have:
Additional Comments