Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the preparation for JCL testing #151

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

std4lqi
Copy link
Collaborator

@std4lqi std4lqi commented Feb 1, 2024

What It Does
Remove JCL preparation from default_properties.yaml, but have test case to check and upload test JCL when needed. This will make it easy for tester do prepare the environment (datasets and uss directories) on z/OS to run system tests.

How to Test
Run test case under __tests__/__system__/cli.

Review Checklist
I certify that I have:

Additional Comments
N/A

Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f38ceb) 73.04% compared to head (d7e4f2a) 73.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   73.04%   73.04%           
=======================================
  Files          80       80           
  Lines         983      983           
  Branches      128      128           
=======================================
  Hits          718      718           
  Misses        244      244           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tiantn tiantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run unit test and system test. All passed. Thank you!

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix @std4lqi

@std4lqi
Copy link
Collaborator Author

std4lqi commented Feb 5, 2024

@JillieBeanSim , @zFernand0 are we OK to merge it with the code duplication check failure on testing code?

@zFernand0
Copy link
Member

zFernand0 commented Feb 5, 2024

JillieBeanSim , zFernand0 are we OK to merge it with the code duplication check failure on testing code?

Hey @std4lqi,
yeah, a lot of times we end up with some duplication due to how tests are structured.
I wouldn't worry too much about code duplication.
image

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding comments to the properties in this file 😋


## Recent Changes

- Simplify the preparation for JCL system tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this requires a new patch to be published.
However we can combine the contents of this PR (after merged) with:

Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

50.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@zFernand0 zFernand0 merged commit 9497b0f into master Feb 5, 2024
16 of 17 checks passed
@zFernand0 zFernand0 deleted the simplify-preparation-for-jcl-tests branch February 5, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants