-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the preparation for JCL testing #151
Conversation
Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 73.04% 73.04%
=======================================
Files 80 80
Lines 983 983
Branches 128 128
=======================================
Hits 718 718
Misses 244 244
Partials 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run unit test and system test. All passed. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the fix @std4lqi
@JillieBeanSim , @zFernand0 are we OK to merge it with the code duplication check failure on testing code? |
Hey @std4lqi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding comments to the properties in this file 😋
|
||
## Recent Changes | ||
|
||
- Simplify the preparation for JCL system tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure this requires a new patch to be published.
However we can combine the contents of this PR (after merged) with:
Quality Gate failedFailed conditions 50.4% Duplication on New Code (required ≤ 3%) |
What It Does
Remove JCL preparation from
default_properties.yaml
, but have test case to check and upload test JCL when needed. This will make it easy for tester do prepare the environment (datasets and uss directories) on z/OS to run system tests.How to Test
Run test case under
__tests__/__system__/cli
.Review Checklist
I certify that I have:
Additional Comments
N/A