Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 2.11.1 & 2.11.2 updates to main #2516

Merged
merged 38 commits into from
Oct 19, 2023
Merged

Port 2.11.1 & 2.11.2 updates to main #2516

merged 38 commits into from
Oct 19, 2023

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Oct 16, 2023

Proposed changes

Port 2.11.1 & 2.11.2 updates to main

Milestone: n/a

Changelog: n/a

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

JillieBeanSim and others added 30 commits September 15, 2023 15:26
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Update maintenance with 2.11.0 changes
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
…& fix paste refresh

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
fix(ds): Sort dataset list by label after adding new children
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
fix(tree,jobs): Various fixes to improve tree UX; add checks for "Delete Job"
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Signed-off-by: zowe-robot <zowe.robot@gmail.com>
Signed-off-by: zowe-robot <zowe.robot@gmail.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
JillieBeanSim and others added 4 commits October 16, 2023 12:01
2.11.2 release that will copy and package secrets with API package
Signed-off-by: zowe-robot <zowe.robot@gmail.com>
Signed-off-by: zowe-robot <zowe.robot@gmail.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 16, 2023
@JillieBeanSim JillieBeanSim self-assigned this Oct 16, 2023
@JillieBeanSim JillieBeanSim changed the title Port 2.11.2 updates to main Port 2.11.1 & 2.11.2 updates to main Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/zowe-explorer/src/dataset/DatasetTree.ts 91.03% <100.00%> (+0.01%) ⬆️
packages/zowe-explorer/src/job/ZosJobsProvider.ts 91.24% <100.00%> (+0.01%) ⬆️
packages/zowe-explorer/src/job/actions.ts 90.87% <ø> (-0.04%) ⬇️
packages/zowe-explorer/src/shared/utils.ts 97.31% <100.00%> (ø)
packages/zowe-explorer/src/uss/USSTree.ts 92.96% <100.00%> (+0.01%) ⬆️
packages/zowe-explorer/src/uss/actions.ts 93.53% <100.00%> (-0.06%) ⬇️
packages/zowe-explorer/src/utils/TreeViewUtils.ts 100.00% <100.00%> (ø)
packages/zowe-explorer/src/uss/ZoweUSSNode.ts 92.23% <75.00%> (-1.07%) ⬇️

📢 Thoughts on this report? Let us know!.

zFernand0
zFernand0 previously approved these changes Oct 16, 2023
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do this right away, but do we want to cleanup the changelog since some packages didn't have anything for 2.11.2 and 2.11.1 😋 ?
Not a showstopper for this PR though.
LGTM! 😋

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
zFernand0
zFernand0 previously approved these changes Oct 17, 2023
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating a few dependencies!
we can worry about the eslint-plugin's changelog later (if we ever decide to start publishing it) 😋
LGTM! 😋

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
traeok
traeok previously approved these changes Oct 19, 2023
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JillieBeanSim

Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@traeok traeok self-requested a review October 19, 2023 18:12
Comment on lines +2703 to +2704
createGlobalMocks();
mocked(vscode.window.createTreeView).mockReturnValueOnce(createTreeView());
Copy link
Member

@traeok traeok Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to consider as a separate issue/task from this PR: I had to change a bunch of mocks/spies in a previous PR so that vscode.window.createTreeView calls didn't break during unit tests. We might want a central resource for VS code mocks so that we do not have to update them in several places. I can see the possibility of this happening again if we start to leverage another TreeView function in the codebase that is not being returned from those mocks.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran unit tests w/ the latest commit, working as expected

@JillieBeanSim JillieBeanSim merged commit 7664664 into main Oct 19, 2023
26 checks passed
@JillieBeanSim JillieBeanSim deleted the port/2.11.2 branch October 19, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants