Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update FTP plug-in version #2712

Merged
merged 5 commits into from
Feb 13, 2024
Merged

fix: Update FTP plug-in version #2712

merged 5 commits into from
Feb 13, 2024

Conversation

zFernand0
Copy link
Member

Resolves #2533

Proposed changes

Update the version of the FTP plug-in in the zFTP extension

Release Notes

Milestone: 2.14.1 (or 2.15.0)

Changelog: Fix Windows-specific hangs when saving members that contain JCL via the FTP extension. Thanks @tiantn & @std4lqi. #2533

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Resolves #2533

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 self-assigned this Feb 12, 2024
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 mentioned this pull request Feb 12, 2024
16 tasks
@zFernand0
Copy link
Member Author

Waiting on the following PR to fix the Audit check:

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04de484) 93.23% compared to head (42db330) 93.23%.

❗ Current head 42db330 differs from pull request most recent head 2de995e. Consider uploading reports for the commit 2de995e to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2712    +/-   ##
========================================
  Coverage   93.23%   93.23%            
========================================
  Files         102      102            
  Lines       10548    10548            
  Branches     2279     2177   -102     
========================================
  Hits         9834     9834            
  Misses        713      713            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zFernand0
Copy link
Member Author

Since the last thing I updates was only the samples directory, you won't see all the build on the last commit.

You can look at the previous commit and see that the ze-build and zftp-build all passed

Here is the complete run though:
https://github.com/zowe/vscode-extension-for-zowe/actions/runs/7887904154/job/21524191412

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @zFernand0

@JillieBeanSim JillieBeanSim merged commit b0fc37b into main Feb 13, 2024
15 checks passed
@JillieBeanSim JillieBeanSim deleted the fix-2533 branch February 13, 2024 14:56
@JillieBeanSim JillieBeanSim mentioned this pull request Feb 14, 2024
16 tasks
@JillieBeanSim JillieBeanSim added this to the v2.14.1 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Members aren't saved, message "Saving data set..." but nothing happens and never ends.
3 participants