Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/stevenh/ui explorer test #1545

Merged
merged 10 commits into from
Sep 14, 2020
Merged

Conversation

stevenhorsman
Copy link
Member

@stevenhorsman stevenhorsman commented Jul 28, 2020

Relevant issues

Fixes #1536

Depends on zowe/explorer-ui-server#37
zowe/explorer-jes#207

Changes proposed in this PR

  • pull in explorer-ui component and add install script for it.

@NakulManchanda NakulManchanda force-pushed the users/stevenh/ui-explorer-test branch 2 times, most recently from 2873baa to 7f684c7 Compare July 29, 2020 04:00
@stevenhorsman stevenhorsman marked this pull request as draft July 30, 2020 08:28
@stevenhorsman
Copy link
Member Author

Converting to draft whilst we decide if we want to continue with the explorer-ui-server separation next release

@NakulManchanda
Copy link
Member

From @1000TurquoisePogs

I had a concern about filesystem structure:

  • this seems like a shared library rather than a component in itself
  • it currently looks that way because it doesnt have its own start.sh script
  • today everything in /components does have a start.sh
    so, today scripting can take for granted /components are all the same type of thing, which could be beneficial for some future management tools.
    i was thinking it would be good to move this new not-quite-component code into a new folder such as /lib or /shared

@NakulManchanda
Copy link
Member

yes, its not used on its own, rather it get called by three explorers
so, we can have some conventions
shared -> looks better to me - as its still an executable
lib -> can be just for non executable things

@NakulManchanda
Copy link
Member

@stevenhorsman @jackjia-ibm
these are ready for review and if all ok, ready to merge
All tests are passing, jack verified the folder structure as well.

old strucutre
component
jes > server app
mvs > server app
uss > server app

Moved structure to new shared folder,
We layout one copy of server instead of three,
We still start three instances of server though.

new structure
component
jes > app
mvs > app
uss > app
shared
explorer-ui-server

As per me,
No documentation required, as for end user, there wont be any difference

Related PR's
zowe/explorer-ui-server#37
zowe/explorer-jes#207
#1545

Copy link
Member

@jackjia-ibm jackjia-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge the other PRs first and modify versions in binaryDependencies.

manifest.json.template Outdated Show resolved Hide resolved
manifest.json.template Outdated Show resolved Hide resolved
stevenhorsman and others added 8 commits September 14, 2020 14:31
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: Nakul Manchanda <nakul.manchanda@ibm.com>
Signed-off-by: Nakul Manchanda <nakul.manchanda@ibm.com>
Signed-off-by: Nakul Manchanda <nakul.manchanda@ibm.com>
Signed-off-by: Nakul Manchanda <nakul.manchanda@ibm.com>
Nakul Manchanda added 2 commits September 14, 2020 14:50
Signed-off-by: Nakul Manchanda <nakul.manchanda@ibm.com>
Signed-off-by: Nakul Manchanda <nakul.manchanda@ibm.com>
@NakulManchanda NakulManchanda marked this pull request as ready for review September 14, 2020 20:11
@jackjia-ibm jackjia-ibm merged commit 8b5706f into staging Sep 14, 2020
@jackjia-ibm jackjia-ibm deleted the users/stevenh/ui-explorer-test branch September 14, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants