Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/bin added near front of PATH #472

Closed
1 of 4 tasks
lvh opened this issue Mar 26, 2018 · 6 comments
Closed
1 of 4 tasks

/bin added near front of PATH #472

lvh opened this issue Mar 26, 2018 · 6 comments

Comments

@lvh
Copy link

lvh commented Mar 26, 2018

  • Type:
    • Bug
    • Enhancement
    • Feature Request
    • Question

  • zplug --version: 2.4.2
  • zsh --version: zsh 5.3.1 (x86_64-redhat-linux-gnu)
  • uname -a: Linux latacora 4.14.18-1.pvops.qubes.x86_64 Implement update command #1 SMP Thu Feb 8 20:01:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Minimal zshrc (with less than 30 lines)

Literally an empty .zshrc. (I'm loading ~/.zplug/init.zsh manually to show the problem.)

Step to reproduce

[user@latacora]~% cat .zshrc 
[user@latacora]~% echo $PATH
/usr/libexec/python2-sphinx:/usr/local/bin:/usr/bin:/home/user/bin:/usr/local/sbin:/usr/sbin
[user@latacora]~% source .zplug/init.zsh 
[user@latacora]~% echo $PATH
/home/user/.zplug/bin:/bin:/usr/libexec/python2-sphinx:/usr/local/bin:/usr/bin:/home/user/bin:/usr/local/sbin:/usr/sbin

Expected behavior: /bin not injected near front of PATH. If it matters, on Fedora /bin is a symlink to /usr/bin. This had the really annoying downside of overriding bin dirs in $HOME.

@lvh
Copy link
Author

lvh commented Mar 26, 2018

The problem does not occur in 9fdb3889e0a131bf2af7bb5cc7ad91ccbf8213e4, but does in master (currently 20ca2c82063f15a2c107069b9af5cd32256e6019).

@lvh
Copy link
Author

lvh commented Mar 26, 2018

after bisection:

3d47ef8f7aaf8179406fd8367435b9dbdea89582 is the first bad commit
commit 3d47ef8f7aaf8179406fd8367435b9dbdea89582
Author: Aoi Tachibana <39e@users.noreply.github.com>
Date:   Wed Feb 14 09:00:58 2018 +0900

    Fix: ZPLUG_BIN for PATH

@lvh
Copy link
Author

lvh commented Mar 26, 2018

Looks like this is really $ZPLUG_ROOT/bin, which is unset. I think there's a bug in that commit, I'll submit a PR.

lvh added a commit to lvh/zplug that referenced this issue Mar 26, 2018
@lvh
Copy link
Author

lvh commented Mar 26, 2018

I think #372 is actually the right way to fix this.

@lvh
Copy link
Author

lvh commented Mar 26, 2018

As a workaround, I'm now setting export ZPLUG_HOME="${HOME}/.zplug" at the top of my .zshrc.

eru added a commit to eru/dotfiles that referenced this issue Mar 28, 2018
filipekiss referenced this issue in ahmedelgabri/dotfiles Apr 2, 2018
@babarot
Copy link
Member

babarot commented May 12, 2018

#476 was finally merged. So perhaps this problem was solved. So I'll close this issue, but if you still have any problems, please contact us again. Thanks

@babarot babarot closed this as completed May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants