-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup paths after variables have been initialized #476
Conversation
Arigatou @39e , this is taking quite a long while now to resolve. |
I merged this P-R so please try it. But I also edited other code. |
Thanks @39e , your fork seems to work well! 🎉 I'll switch over to it for a while and see how it goes 👍 |
My apologies if any of this is duplicate information... A brand-new zplug install after $ tr ':' '\n' <<< "$PATH" | grep zplug
/home/tlambiris/.zplug/bin
$ env | ag "ZPLUG_(HOME|ROOT)"
ZPLUG_ROOT=/home/tlambiris/.zplug
ZPLUG_HOME=/home/tlambiris/.zplug Immediately opening a new terminal: $ tr ':' '\n' <<< "$PATH" | grep zplug
/home/tlambiris/.zplug/repos/zplug/zplug/bin
$ env | ag "ZPLUG_(HOME|ROOT)"
ZPLUG_ROOT=/home/tlambiris/.zplug/repos/zplug/zplug
ZPLUG_HOME=/home/tlambiris/.zplug My zshrc setup can be found in it's entirety here: https://github.com/tonylambiris/dotfiles/ Thanks in advance. |
@tonylambiris Please try 39e/zplug |
Latest commit seemed to have fixed this for me: New terminal:
|
Sorry for everyone. I finally merged this. I am sorry to have kept you waiting so long. |
@b4b4r07 it's okay! Life happens; your work is appreciated nonetheless. Do you need an additional maintainer to monitor PRs and solicit feedback? I'm happy to help, if you're becoming too busy for zplug! |
@ELLIOTTCABLE Thank you for understanding me! Yeah, if there is those who can understand zsh script and want to contribute to zplug, I'm thinking of adding as a maintainer. This may make the development of zplug more rich. By the way, while I was out of this project, I have seen various OSS communities. Especially the development process of projects such as Kubernetes and Istio seems to be mature awfully. The same is true for Mac's package manager, Brew. I would like to refer to them and would like to improve the development process of zplug. Thank you :-) |
@b4b4r07 cool! It's always excellent to learn from the greats of our communities. Feel free to reach out on Twitter or Freenode (both places, same name as here), if you want to chat more. |
base: #372
Fix: #453 #472
Set
PATH
after__zplug::core::core::variable
環境変数が宣言される前にPATHを追加しようとしてたので変更
@b4b4r07 確認お願いします