Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup paths after variables have been initialized #476

Merged
merged 1 commit into from May 12, 2018
Merged

Setup paths after variables have been initialized #476

merged 1 commit into from May 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2018

base: #372
Fix: #453 #472

Set PATH after __zplug::core::core::variable


環境変数が宣言される前にPATHを追加しようとしてたので変更

@b4b4r07 確認お願いします

@zakame
Copy link

zakame commented Apr 9, 2018

Arigatou @39e , this is taking quite a long while now to resolve.

@ghost
Copy link
Author

ghost commented Apr 9, 2018

I merged this P-R so please try it.
39e/zplug

But I also edited other code.
master...39e:master

@zakame
Copy link

zakame commented Apr 16, 2018

Thanks @39e , your fork seems to work well! 🎉 I'll switch over to it for a while and see how it goes 👍

@tonylambiris
Copy link

My apologies if any of this is duplicate information...

A brand-new zplug install after rm -rf ~/.zplug:

$ tr ':' '\n' <<< "$PATH" | grep zplug
/home/tlambiris/.zplug/bin
$ env | ag "ZPLUG_(HOME|ROOT)"        
ZPLUG_ROOT=/home/tlambiris/.zplug
ZPLUG_HOME=/home/tlambiris/.zplug

Immediately opening a new terminal:

$ tr ':' '\n' <<< "$PATH" | grep zplug
/home/tlambiris/.zplug/repos/zplug/zplug/bin
$ env | ag "ZPLUG_(HOME|ROOT)" 
ZPLUG_ROOT=/home/tlambiris/.zplug/repos/zplug/zplug
ZPLUG_HOME=/home/tlambiris/.zplug

My zshrc setup can be found in it's entirety here: https://github.com/tonylambiris/dotfiles/

Thanks in advance.

@ghost
Copy link
Author

ghost commented May 7, 2018

@tonylambiris Please try 39e/zplug

@ndxbn ndxbn mentioned this pull request May 7, 2018
3 tasks
@tonylambiris
Copy link

Latest commit seemed to have fixed this for me:

New terminal:

$ tr ':' '\n' <<< "$PATH" | grep zplug
/home/tlambiris/.zplug/repos/zplug/zplug/bin
/home/tlambiris/.zplug/bin

$ env | ag "ZPLUG_(HOME|ROOT)" 
ZPLUG_HOME=/home/tlambiris/.zplug
ZPLUG_ROOT=/home/tlambiris/.zplug/repos/zplug/zplug

$ which fzf       
/home/tlambiris/.zplug/bin/fzf

@babarot babarot merged commit 08c76dc into zplug:master May 12, 2018
@babarot
Copy link
Member

babarot commented May 12, 2018

Sorry for everyone. I finally merged this. I am sorry to have kept you waiting so long.

@babarot babarot mentioned this pull request May 12, 2018
4 tasks
@ELLIOTTCABLE
Copy link

@b4b4r07 it's okay! Life happens; your work is appreciated nonetheless.

Do you need an additional maintainer to monitor PRs and solicit feedback? I'm happy to help, if you're becoming too busy for zplug!

@babarot
Copy link
Member

babarot commented May 13, 2018

@ELLIOTTCABLE Thank you for understanding me!

Yeah, if there is those who can understand zsh script and want to contribute to zplug, I'm thinking of adding as a maintainer. This may make the development of zplug more rich. By the way, while I was out of this project, I have seen various OSS communities. Especially the development process of projects such as Kubernetes and Istio seems to be mature awfully. The same is true for Mac's package manager, Brew. I would like to refer to them and would like to improve the development process of zplug. Thank you :-)

@ghost ghost deleted the fix/setup-paths branch May 14, 2018 00:52
@ELLIOTTCABLE
Copy link

@b4b4r07 cool! It's always excellent to learn from the greats of our communities.

Feel free to reach out on Twitter or Freenode (both places, same name as here), if you want to chat more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants