Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enhanced zpa rate-limit with retry-after header tracking #100

Merged
merged 10 commits into from
May 29, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented May 28, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@willguibr willguibr self-assigned this May 28, 2024
@willguibr willguibr added bug Something isn't working enhancement New feature or request python Pull requests that update Python code In development Under active development new-acceptance-tests New acceptance tests new-attributes ZPA API Added New Parameters ZPA New API Resources ZPA New API Resources labels May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 66.33%. Comparing base (78b1ab5) to head (5b621ba).

Files Patch % Lines
zscaler/zpa/__init__.py 56.66% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   60.50%   66.33%   +5.82%     
==========================================
  Files          53       52       -1     
  Lines        3773     3915     +142     
==========================================
+ Hits         2283     2597     +314     
+ Misses       1490     1318     -172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 May 29, 2024 17:12 — with GitHub Actions Inactive
@willguibr willguibr merged commit afda28e into master May 29, 2024
10 of 11 checks passed
github-actions bot pushed a commit that referenced this pull request May 29, 2024
### [0.3.1](v0.3.0...v0.3.1) (2024-05-29)

### Bug Fixes

* Enhanced zpa rate-limit with retry-after header tracking ([#100](#100)) ([afda28e](afda28e))
Copy link

🎉 This PR is included in version 0.3.1 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request In development Under active development new-acceptance-tests New acceptance tests new-attributes ZPA API Added New Parameters python Pull requests that update Python code released ZPA New API Resources ZPA New API Resources
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

1 participant