Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross platform md5 #73

Merged
merged 1 commit into from
Oct 26, 2013
Merged

cross platform md5 #73

merged 1 commit into from
Oct 26, 2013

Conversation

coreyjewett
Copy link
Contributor

No description provided.

@coreyjewett
Copy link
Contributor Author

OSX uses BSD's md5 v.s. Linux's md5sum. This should make snapshot work with either toolchain, but I have only tested on OSX.

sharat87 added a commit that referenced this pull request Oct 26, 2013
Fix MD5 hashing command being different on OSX.
@sharat87 sharat87 merged commit a3e1a35 into zsh-users:master Oct 26, 2013
@sharat87
Copy link
Member

Merged. Thank you for the PR and thanks for testing this feature out :)

I'm not sure if we should add a new global called "chksum", might conflict with some other scripts or functions in other scripts. We'll see how we can rectify that, but for now, 🍰!

@neoascetic
Copy link

If you use brew (which, probably, use most of users of zsh and antigen), you always can install md5sha1sum which provides md5sum executable.

Also, wouldn't it be better to detect which executable run using whence md5sum || whence md5?

@GUIpsp
Copy link
Contributor

GUIpsp commented Oct 27, 2013

hint:

[guipsp@localhost ~]$ command -v md5sum
/usr/bin/md5sum
[guipsp@localhost ~]$ echo $?
0
[guipsp@localhost ~]$ command -v md5
[guipsp@localhost ~]$ echo $?
1

(command is also posix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants