Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generate config.yaml on shell start #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vegerot
Copy link

@vegerot vegerot commented Sep 9, 2019

I think the current instruction for updating keys is slightly unintuitive
Having to manually run ruby generate.rb is different than the way users might expect. Instead, I think it makes more sense to ask users to resource ~/.zshrc or restart their terminal.

I don't think it's BETTER to restart zsh/resource ~/.zshrc (in fact, it's actually slower), but rather it fits more in line with standard command-line tools conventions. Most CLI tools I know of may ask users to restart/resource their shell to apply changes.

Anyways, this PR isn't trying to change any functionality of zsh-apple-touchbar, just making a bit more sense for once process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant