Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocompletion for qmk. #805

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Autocompletion for qmk. #805

merged 1 commit into from
Jun 28, 2021

Conversation

undg
Copy link
Contributor

@undg undg commented Jun 22, 2021 •
edited

  • [*] This compdef is not already available in zsh.
  • [*] This compdef is not already available in their original project.
  • [*] I am the original author, or I have authorization to submit this work.
  • [*] This is a finished work.
  • [*] It has a header containing authors, status and origin of the script.
  • [*] It has a license header or I accept that it will be licensed under the terms of the Zsh license.

Completion for all arguments and for many options in QMK CLI
image
image

syohex
syohex reviewed Jun 23, 2021
View reviewed changes
src/_qmk Outdated Show resolved Hide resolved
src/_qmk Outdated Show resolved Hide resolved
src/_qmk Outdated Show resolved Hide resolved
@undg
Copy link
Contributor Author

undg commented Jun 23, 2021

@syohex Thank's for your suggestion.

I've checked all commands against the newest version QMK CLI and it looks like now we have all commands and flags.

@undg
Copy link
Contributor Author

undg commented Jun 23, 2021

...And renamed commits.

syohex
syohex reviewed Jun 24, 2021
View reviewed changes
Copy link
Contributor

@syohex syohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I mistook to approve. But I have some comments.

src/_qmk Outdated Show resolved Hide resolved
src/_qmk Outdated Show resolved Hide resolved
@undg undg requested a review from syohex June 25, 2021 08:03
syohex
syohex reviewed Jun 25, 2021
View reviewed changes
src/_qmk Outdated Show resolved Hide resolved
src/_qmk Outdated Show resolved Hide resolved
src/_qmk Show resolved Hide resolved
@undg undg requested a review from syohex June 27, 2021 12:01
syohex
syohex approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@syohex syohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@undg thanks looks good. Cloud you squash commits before merging ?

@undg
Copy link
Contributor Author

undg commented Jun 28, 2021 •
edited

@syohex thx for your help.

Sure I can squash it.

@syohex syohex merged commit a736cfe into zsh-users:master Jun 28, 2021
@undg undg deleted the qmk branch August 14, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syohex syohex syohex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@undg @syohex