add completion for trash-d

[mirsella]

https://github.com/rushsteve1/trash-d

I don't know if this is feasible since there is already Darwin/command/_trash for another trash command,
but since this one is in Linux/, maybe it can work, as there shouldn't be a system where both Darwin and Linux exist.

thanks !

[danielshahaf]

See ${_comps[watch]} for how to deal with name clashes (two unrelated commands of the same name). Excuse brevity.

[mirsella]

See ${_comps[watch]} for how to deal with name clashes (two unrelated commands of the same name). Excuse brevity.

thanks l will look into it !

[mirsella]

i found about _pick_variant.
i'll try to make one _trash completion file, put it in Unix that will manage both trash command on macos and linux, tell me if it's not like that it should be made.

thanks !

[mirsella]

well, i tried, but it's not working for the second case with author=steven. can't test for the macos version.

looking for help !

[mirsella]

update: it's working for trash-d, but i can't test for the macos version

[okdana]

Didn't test the current function or my suggestions, here's my feedback anyway

[mirsella]

@okdana thanks for the feedback !
I hope the changes I made were good.

Would be really nice if we manage to make the completion file from the trash (for --delete, --restore) complete from trash --list including the date of deletion, instead of from a folder, so that we can determine which duplicate file name we want in a case where multiple filename-[0-9]{4} exist.

[okdana]

It looks more like how i'd expect now. A few more things, though, mostly stuff i didn't notice before about how the command works

[mirsella]

i'll try to use grouping options, but i can't figure it out for now

[okdana]

One more round, mostly nit-picking, but improving the exclusions on the actions group at least would be nice. Otherwise, i tested both variants, and it seems good

[mirsella]

I'm not sure about some modifications, sorry if there are still problems.
Thanks for taking the time to improve the design.

[okdana]

Yeah i think it's good. I'll merge this in a day or two if nobody else has anything to say. Thank you

[okdana]

Committed as 5ec4695. Sorry for the delay, thanks again