Update module github.com/gofiber/fiber/v2 to v2.52.5 [SECURITY] #40

renovate · 2023-10-17T13:43:45Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
github.com/gofiber/fiber/v2	`v2.49.2` -> `v2.52.5`

GitHub Vulnerability Alerts

CVE-2023-45128

A Cross-Site Request Forgery (CSRF) vulnerability has been identified in the application, which allows an attacker to inject arbitrary values and forge malicious requests on behalf of a user. This vulnerability can allow an attacker to inject arbitrary values without any authentication, or perform various malicious actions on behalf of an authenticated user, potentially compromising the security and integrity of the application.

Vulnerability Details

The vulnerability is caused by improper validation and enforcement of CSRF tokens within the application. The following issues were identified:

Token Injection: For 'safe' methods, the token was extracted from the cookie and saved to storage without further validation or sanitization.
Lack of Token Association: The CSRF token was validated against tokens in storage but not associated with a session, nor by using a Double Submit Cookie Method, allowing for token reuse.

Specific Go Packages Affected

github.com/gofiber/fiber/v2/middleware/csrf

Remediation

To remediate this vulnerability, it is recommended to take the following actions:

Update the Application: Upgrade the application to a fixed version with a patch for the vulnerability.
Implement Proper CSRF Protection: Review the updated documentation and ensure your application's CSRF protection mechanisms follow best practices.
Choose CSRF Protection Method: Select the appropriate CSRF protection method based on your application's requirements, either the Double Submit Cookie method or the Synchronizer Token Pattern using sessions.
Security Testing: Conduct a thorough security assessment, including penetration testing, to identify and address any other security vulnerabilities.

Defence-in-depth

Users should take additional security measures like captchas or Two-Factor Authentication (2FA) and set Session cookies with SameSite=Lax or SameSite=Secure, and the Secure and HttpOnly attributes.

CVE-2023-45141

A Cross-Site Request Forgery (CSRF) vulnerability has been identified in the application, which allows an attacker to obtain tokens and forge malicious requests on behalf of a user. This can lead to unauthorized actions being taken on the user's behalf, potentially compromising the security and integrity of the application.

Vulnerability Details

The vulnerability is caused by improper validation and enforcement of CSRF tokens within the application. The following issues were identified:

Lack of Token Association: The CSRF token was validated against tokens in storage but was not tied to the original requestor that generated it, allowing for token reuse.

Remediation

To remediate this vulnerability, it is recommended to take the following actions:

Update the Application: Upgrade the application to a fixed version with a patch for the vulnerability.
Implement Proper CSRF Protection: Review the updated documentation and ensure your application's CSRF protection mechanisms follow best practices.
Choose CSRF Protection Method: Select the appropriate CSRF protection method based on your application's requirements, either the Double Submit Cookie method or the Synchronizer Token Pattern using sessions.
Security Testing: Conduct a thorough security assessment, including penetration testing, to identify and address any other security vulnerabilities.

Defence-in-depth

Users should take additional security measures like captchas or Two-Factor Authentication (2FA) and set Session cookies with SameSite=Lax or SameSite=Strict, and the Secure and HttpOnly attributes.

CVE-2024-25124

The CORS middleware allows for insecure configurations that could potentially expose the application to multiple CORS-related vulnerabilities. Specifically, it allows setting the Access-Control-Allow-Origin header to a wildcard ("*") while also having the Access-Control-Allow-Credentials set to true, which goes against recommended security best practices.

Impact

The impact of this misconfiguration is high as it can lead to unauthorized access to sensitive user data and expose the system to various types of attacks listed in the PortSwigger article linked in the references.

Proof of Concept

The code in cors.go allows setting a wildcard in the AllowOrigins while having AllowCredentials set to true, which could lead to various vulnerabilities.

Potential Solution

Here is a potential solution to ensure the CORS configuration is secure:

func New(config ...Config) fiber.Handler {
    if cfg.AllowCredentials && cfg.AllowOrigins == "*" {
        panic("[CORS] Insecure setup, 'AllowCredentials' is set to true, and 'AllowOrigins' is set to a wildcard.")
    }
    // Return new handler goes below
}

The middleware will not allow insecure configurations when using `AllowCredentials` and `AllowOrigins`.

Workarounds

For the meantime, users are advised to manually validate the CORS configurations in their implementation to ensure that they do not allow a wildcard origin when credentials are enabled. The browser fetch api, browsers and utilities that enforce CORS policies are not affected by this.

References

MDN Web Docs on CORS Errors
CodeQL on CORS Misconfiguration
PortSwigger on Exploiting CORS Misconfigurations
WhatWG CORS protocol and credentials

CVE-2024-38513

A security vulnerability has been identified in the Fiber session middleware where a user can supply their own session_id value, leading to the creation of a session with that key.

Impact

The identified vulnerability is a session middleware issue in GoFiber versions 2 and above. This vulnerability allows users to supply their own session_id value, resulting in the creation of a session with that key. If a website relies on the mere presence of a session for security purposes, this can lead to significant security risks, including unauthorized access and session fixation attacks. All users utilizing GoFiber's session middleware in the affected versions are impacted.

Patches

The issue has been addressed in the latest patch. Users are strongly encouraged to upgrade to version 2.52.5 or higher to mitigate this vulnerability.

Workarounds

Users who are unable to upgrade immediately can apply the following workarounds to reduce the risk:

Validate Session IDs: Implement additional validation to ensure session IDs are not supplied by the user and are securely generated by the server.
Session Management: Regularly rotate session IDs and enforce strict session expiration policies.

References

For more information on session best practices:

OWASP Session Management Cheat Sheet

Users are encouraged to review these references and take immediate action to secure their applications.

Release Notes

gofiber/fiber (github.com/gofiber/fiber/v2)

`v2.52.5`

Compare Source

👮 Security

Middleware/session: Session Middleware Token Injection Vulnerability - GHSA-98j2-3j3p-fw2v

https://docs.gofiber.io/api/middleware/session

🧹 Updates

Middleware/session: Remove extra release and aquire ctx calls in session_test.go (#3043)

🐛 Bug Fixes

Middleware/monitor: middleware reporting of CPU usage (#2984)
Middleware/session: mutex for thread safety (#3050)

📚 Documentation

Improve ctx.Locals method description and example (#3030)
Improve ctx.Locals method documentation (#3033)
Update README_id.md (#3045)

Fix default value to false in docs of QueryBool (#2811)
Fix code snippet indentation in /docs/api/middleware/keyauth.md (#2867)

Full Changelog: gofiber/fiber@v2.52.0...v2.52.1

Thank you @luk3skyw4lker, @CAEL0, @grivera64, @gaby and @sixcolors for making this update possible.

`v2.52.0`

Compare Source

🚀 New

Middleware/healthcheck: Add liveness and readiness checks (#2509)
https://docs.gofiber.io/api/middleware/healthcheck

// Direct usage with default config
app.Use(healthcheck.New())

// Or extend your config for customization
app.Use(healthcheck.New(healthcheck.Config{
    LivenessEndpoint: "/live",
    LivenessProbe: func(c *fiber.Ctx) bool {
        return true
    },
    ReadinessEndpoint: "/ready",
    ReadinessProbe: func(c *fiber.Ctx) bool {
        return serviceA.Ready() && serviceB.Ready() && ...
    },
}))

🧹 Updates

Middlewares: don't constrain middlewares context-keys to strings (#2751)
Middleware/logger: colorize logger error message #2593 (#2773)
Middleware/logger: changing default log output (#2730)
Middleware/logger: log client IP address by default (#2755)
Middleware/encryptcookie: update default config (#2753)
Improve benchmarks for getOffer (#2739)

🛠️ Maintenance

Bump github/codeql-action from 2 to 3 (#2763)
Bump github.com/google/uuid from 1.4.0 to 1.5.0 (#2762)
Bump actions/setup-go from 4 to 5 (#2754)
Bump golang.org/x/sys from 0.14.0 to 0.15.0 (#2744)
Bump github.com/valyala/fasthttp from 1.50.0 to 1.51.0 (#2721)

🐛 Fixes

Middleware/redirect : fix for redirect with query params (#2748)
Middleware/adaptor: Adaptor + otelfiber issue #2641 (#2772)
Middleware/cors: Should use the defined AllowedOriginsFunc config when AllowedOrigins is empty (#2771)
Middleware/session: Race in session middleware tests (#2740)
Middleware/csrf: Fix failing CSRF tests (#2720)
Fix race condition in parallel tests (#2734)
utils.IsIPv4 and net.ParseIP have inconsistent results #2735 (#2736)

📚 Documentation

Middleware/csrf: Improve csrf docs (#2726)
Update app.md for indentation (#2761)
Update default config (#2753)
Update CONTRIBUTING.md (#2752)

Full Changelog: gofiber/fiber@v2.51.0...v2.52.0

Thank you @MehmetFiratKomurcu, @benjajaja, @brunodmartins, @gilwo, @iredmail, @itswcg, @luk3skyw4lker, @muhammadkholidb, @nickajacks1, @sixcolors and @tokelo-12 for making this update possible.

`v2.51.0`

Compare Source

🚀 New

Add support for parameters in content negotiation (#2678) RFC
https://docs.gofiber.io/api/ctx#accepts

// Consideration of parameters in the accepted headers
// Accept: text/plain, application/json; version=1; foo=bar

app.Get("/", func(c *fiber.Ctx) error {
  // Extra parameters in the accept are ignored
  c.Accepts("text/plain;format=flowed") // "text/plain;format=flowed"

  // An offer must contain all parameters present in the Accept type
  c.Accepts("application/json") // ""

  // Parameter order and capitalization does not matter. Quotes on values are stripped.
  c.Accepts(`application/json;foo="bar";VERSION=1`) // "application/json;foo="bar";VERSION=1"
})

Add support for application/problem+json (#2704)
https://docs.gofiber.io/api/ctx#json
https://docs.gofiber.io/api/client#json

// Passing a custom json type
ctx.JSON(fiber.Map{
    "type": "https://example.com/probs/out-of-credit",
    "title": "You do not have enough credit.",
    "status": 403,
    "detail": "Your current balance is 30, but that costs 50.",
    "instance": "/account/12345/msgs/abc",
  }, fiber.)

🧹 Updates

Ctx.Range: reduce allocations (#2705)
Middleware/pprof: improve performance (#2709)

🛠️ Maintenance

Bump golang.org/x/sys from 0.13.0 to 0.14.0 (#2707)
Bump github.com/google/uuid from 1.3.1 to 1.4.0 (#2693)
Bump actions/setup-node from 3 to 4 (#2690)
Bump github.com/mattn/go-isatty from 0.0.19 to 0.0.20 (#2679)

🐛 Fixes

Middleware/limiter: fix intermittent failures (#2716)
Naming of routes works wrong after mount #2688 (#2689)
Fix method validation on route naming (#2686)

📚 Documentation

Changed "Twitter" to "X (Twitter)" in README.md Contribute Section (#2696)
Add additional information as to why GetReqHeaders returns a map where the values are slices of strings (#2698)
Enhance csrf.md (#2692)

Full Changelog: gofiber/fiber@v2.50.0...v2.51.0

Thank you @BandhiyaHardik, @database64128, @efectn, @moritz157, @nickajacks1, @rhburt and @sixcolors for making this update possible.

`v2.50.0`

Compare Source

❗ Breaking Changes

Change signatures of GetReqHeaders and GetRespHeaders (#2650)

To allow single and list values under headers according to the rfc standard

- func (c *Ctx) GetReqHeaders() map[string]string
+ func (c *Ctx) GetReqHeaders() map[string][]string

- func (c *Ctx) GetRespHeaders() map[string]string
+ func (c *Ctx) GetRespHeaders() map[string][]string

👮 Security

Middleware/csrf: Token Vulnerability (GHSA-mv73-f69x-444p, GHSA-94w9-97p3-p368)

https://docs.gofiber.io/api/middleware/csrf

🚀 Improvements to the CSRF middleware:

Added support for single-use tokens through the SingleUseToken configuration option.
Optional integration with GoFiber session middleware through the Session and SessionKey configuration options.
Introduction of origin checks for HTTPS connections to verify referer headers.
Implementation of a Double Submit Cookie approach for CSRF token generation and validation when used without Session.
Enhancement of error handling with more descriptive error messages.
The documentation for the CSRF middleware has been enhanced with the addition of the new options and best practices to improve security.

Thank you @sixcolors

🚀 New

Cookie parser (#2656)
https://docs.gofiber.io/api/ctx#cookieparser

// Field names should start with an uppercase letter
type Person struct {
    Name     string  `cookie:"name"`
    Age      int     `cookie:"age"`
    Job      bool    `cookie:"job"`
}
// Example route
app.Get("/", func(c *fiber.Ctx) error {
    p := new(Person)
    // This method is similar to BodyParser, but for cookie parameters
    if err := c.CookieParser(p); err != nil {
        return err
    }
    
    log.Println(p.Name)     // Joseph
    log.Println(p.Age)      // 23
    log.Println(p.Job)      // true
})

Middleware/cors: Allow disabling caching in preflight requests (#2649)
https://docs.gofiber.io/api/middleware/cors#config

// To disable caching completely, pass MaxAge value negative. It will set the Access-Control-Max-Age header 0.
app.Use(cors.New(cors.Config{MaxAge: -1}))

Middleware/session: Add Reset method to Session struct in session middleware (#2654)
https://docs.gofiber.io/api/middleware/session#signatures

// Provide more flexibility in session management, especially in scenarios like repeated user logins
func (s *Session) Reset() error

Example usage:

// Initialize default config
// This stores all of your app's sessions
store := session.New()

app.Post("/login", func(c *fiber.Ctx) error {
    // Get session from storage
    sess, err := store.Get(c)
    if err != nil {
        panic(err)
    }
    
    // ... validate login ...
    
    // Check if the session is fresh
    if !sess.Fresh() {
        // If the session is not fresh, reset it
        if err := sess.Reset(); err != nil {
            panic(err)
        }
    }
    // Set new session data
    sess.Set("user_id", user.ID)
    // Save session
    if err := sess.Save(); err != nil {
        panic(err)
    }

    return c.SendString(fmt.Sprintf("Welcome %v", user.ID))
})

Middleware/session: Add Delete method to Store struct in session middleware (#2655)
https://docs.gofiber.io/api/middleware/session#signatures

// Provide more control over individual session management, especially in scenarios 
// like administrator-enforced user logout or user-initiated logout from a specific device session
func (s *Store) Delete(id string) error

Example usage:

app.Post("/admin/session/:id/logout", func(c *fiber.Ctx) error {
    // Get session id from request
    sessionID := c.Params("id")

    // Delete the session
    if err := store.Delete(sessionID); err != nil {
        return c.Status(500).SendString(err.Error())
    }

    return c.SendString("Logout successful")
})

🧹 Updates

Middleware/filesystem: Improve status for SendFile (#2664)
Middleware/filesystem: Set response code (#2632)
Refactor Ctx.Method func to improve code readability (#2647)

🛠️ Maintenance

Fix loop variable captured by func literal (#2660)
Run gofumpt and goimports (#2662)
Use utils.AssertEqual instead of t.Fatal on some tests (#2653)
Apply go fix ./... with latest version of go in repository (#2661)
Bump github.com/valyala/fasthttp from 1.49.0 to 1.50.0 (#2634)
Bump golang.org/x/sys from 0.12.0 to 0.13.0 (#2665)

🐛 Fixes

Path checking on route naming (#2676)
Incorrect log depth when use log.WithContext (#2666)
Jsonp ignoring custom json encoder (#2658)
PassLocalsToView when bind parameter is nil (#2651)
Parse ips return invalid in abnormal case (#2642)
Bug parse custom header (#2638)
Middleware/adaptor: Reduce memory usage by replacing io.ReadAll() with io.Copy() (#2637)
Middleware/idempotency: Nil pointer dereference issue on idempotency middleware (#2668)

📚 Documentation

Incorrect status code source (#2667)
Middleware/requestid: Typo in requestid.md (#2675)
Middleware/cors: Update docs to better explain AllowOriginsFunc (#2652)

Full Changelog: gofiber/fiber@v2.49.2...v2.50.0

Thank you @KaptinLin, @Skyenought, @cuipeiyu, @dairlair, @efectn, @gaby, @geerew, @huykn, @jimmyl02, @joey1123455, @joshlarsen, @jscappini, @peczenyj and @sixcolors for making this update possible.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate · 2024-07-01T21:09:23Z

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

5 additional dependencies were updated

Details:

Package	Change
`github.com/google/uuid`	`v1.3.1` -> `v1.5.0`
`github.com/valyala/fasthttp`	`v1.49.0` -> `v1.51.0`
`github.com/mattn/go-isatty`	`v0.0.19` -> `v0.0.20`
`golang.org/x/net`	`v0.10.0` -> `v0.17.0`
`golang.org/x/sys`	`v0.13.0` -> `v0.15.0`

renovate bot changed the title ~~Update module github.com/gofiber/fiber/v2 to v2.50.0 [SECURITY]~~ Update module github.com/gofiber/fiber/v2 to v2.50.0 [SECURITY] - autoclosed Oct 23, 2023

renovate bot closed this Oct 23, 2023

renovate bot deleted the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch October 23, 2023 09:39

renovate bot changed the title ~~Update module github.com/gofiber/fiber/v2 to v2.50.0 [SECURITY] - autoclosed~~ Update module github.com/gofiber/fiber/v2 to v2.50.0 [SECURITY] Oct 23, 2023

renovate bot reopened this Oct 23, 2023

renovate bot restored the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch October 23, 2023 14:45

renovate bot force-pushed the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch from 75d66e5 to fe0ba84 Compare October 23, 2023 14:46

renovate bot force-pushed the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch 4 times, most recently from 81fc038 to 6bff17c Compare November 9, 2023 13:28

renovate bot force-pushed the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch from 6bff17c to b46db41 Compare November 15, 2023 13:24

renovate bot changed the title ~~Update module github.com/gofiber/fiber/v2 to v2.50.0 [SECURITY]~~ Update module github.com/gofiber/fiber/v2 to v2.52.1 [SECURITY] Feb 22, 2024

renovate bot force-pushed the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch 2 times, most recently from 09281b4 to cf72653 Compare February 28, 2024 03:03

Update module github.com/gofiber/fiber/v2 to v2.52.5 [SECURITY]

fdaee58

renovate bot force-pushed the renovate/go-github.com/gofiber/fiber/v2-vulnerability branch from cf72653 to fdaee58 Compare July 1, 2024 21:09

renovate bot changed the title ~~Update module github.com/gofiber/fiber/v2 to v2.52.1 [SECURITY]~~ Update module github.com/gofiber/fiber/v2 to v2.52.5 [SECURITY] Jul 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update module github.com/gofiber/fiber/v2 to v2.52.5 [SECURITY] #40

Update module github.com/gofiber/fiber/v2 to v2.52.5 [SECURITY] #40

renovate bot commented Oct 17, 2023 •

edited

Loading

renovate bot commented Jul 1, 2024

Update module github.com/gofiber/fiber/v2 to v2.52.5 [SECURITY] #40

Are you sure you want to change the base?

Update module github.com/gofiber/fiber/v2 to v2.52.5 [SECURITY] #40

Conversation

renovate bot commented Oct 17, 2023 • edited Loading

GitHub Vulnerability Alerts

Vulnerability Details

Specific Go Packages Affected

Remediation

Defence-in-depth

Vulnerability Details

Remediation

Defence-in-depth

Impact

Proof of Concept

Potential Solution

Workarounds

References

Impact

Patches

Workarounds

References

Release Notes

👮 Security

🧹 Updates

🐛 Bug Fixes

📚 Documentation

🐛 Fixes

🐛 Fixes

🐛 Fixes

👮 Security

🐛 Fixes

📚 Documentation

🚀 New

🧹 Updates

🛠️ Maintenance

🐛 Fixes

📚 Documentation

🚀 New

🧹 Updates

🛠️ Maintenance

🐛 Fixes

📚 Documentation

❗ Breaking Changes

👮 Security

🚀 New

🧹 Updates

🛠️ Maintenance

🐛 Fixes

📚 Documentation

Configuration

renovate bot commented Jul 1, 2024

ℹ Artifact update notice

File name: go.mod

renovate bot commented Oct 17, 2023 •

edited

Loading